Address review comments

Author: hvitved

rust/ql/.generated.list

@@ -1,4 +1,3 @@
-// generated by codegen, remove this comment if you wish to edit this file
 /**
  * This module provides a hand-modifiable wrapper around the generated class `AssocTypeArg`.
  *
@@ -12,6 +11,7 @@ private import codeql.rust.elements.internal.generated.AssocTypeArg
  * be referenced directly.
  */
 module Impl {
+  // the following QLdoc is generated: if you need to edit it, do it in the schema file
   /**
    * An associated type argument in a path.
    *
@@ -26,5 +26,12 @@ module Impl {
    * }
    * ```
    */
-  class AssocTypeArg extends Generated::AssocTypeArg { }
+  class AssocTypeArg extends Generated::AssocTypeArg {
+    /** Gets the type representation for the associated type argument `name`. */
+    pragma[nomagic]
+    TypeRepr getTypeRepr(string name) {
+      result = this.getTypeRepr() and
+      name = this.getIdentifier().getText()
+    }
+  }
 }

rust/ql/.gitattributes

@@ -112,10 +112,7 @@ private module Input2 implements InputSig2 {
 
   class TypeMention = TM::TypeMention;
 
-  TypeMention getABaseTypeMention(Type t) {
-    result =
-      t.(ImplTraitReturnType).getImplTraitTypeRepr().getTypeBoundList().getABound().getTypeRepr()
-  }
+  TypeMention getABaseTypeMention(Type t) { none() }
 
   TypeMention getATypeParameterConstraint(TypeParameter tp) {
     result = tp.(TypeParamTypeParameter).getTypeParam().getTypeBoundList().getABound().getTypeRepr()

rust/ql/lib/codeql/rust/elements/internal/AssocTypeArgImpl.qll

@@ -56,6 +56,32 @@ class PathTypeReprMention extends TypeMention instanceof PathTypeRepr {
 
   ItemNode getResolved() { result = resolved }
 
+  pragma[nomagic]
+  private TypeAlias getResolvedTraitAlias(string name) {
+    exists(TraitItemNode trait |
+      trait = resolvePath(path) and
+      result = trait.getAnAssocItem() and
+      name = result.getName().getText()
+    )
+  }
+
+  pragma[nomagic]
+  private TypeRepr getAssocTypeArg(string name) {
+    exists(AssocTypeArg arg |
+      arg = path.getSegment().getGenericArgList().getAGenericArg() and
+      result = arg.getTypeRepr(name)
+    )
+  }
+
+  /** Gets the type argument for the associated type `alias`, if any. */
+  pragma[nomagic]
+  private TypeRepr getAnAssocTypeArgument(TypeAlias alias) {
+    exists(string name |
+      alias = this.getResolvedTraitAlias(name) and
+      result = this.getAssocTypeArg(name)
+    )
+  }
+
   override TypeMention getTypeArgument(int i) {
     result = path.getSegment().getGenericArgList().getTypeArg(i)
     or
@@ -96,6 +122,11 @@ class PathTypeReprMention extends TypeMention instanceof PathTypeRepr {
       result = alias.getTypeRepr() and
       param.getIndex() = i
     )
+    or
+    exists(TypeAlias alias |
+      result = this.getAnAssocTypeArgument(alias) and
+      traitAliasIndex(_, i, alias)
+    )
   }
 
   /**
@@ -150,44 +181,6 @@ class PathTypeReprMention extends TypeMention instanceof PathTypeRepr {
     not exists(resolved.(TypeAlias).getTypeRepr()) and
     result = super.resolveTypeAt(typePath)
   }
-
-  pragma[nomagic]
-  private TypeAlias getResolvedTraitAlias(string name) {
-    exists(TraitItemNode trait |
-      trait = resolvePath(path) and
-      result = trait.getAnAssocItem() and
-      name = result.getName().getText()
-    )
-  }
-
-  pragma[nomagic]
-  private TypeRepr getAssocTypeArg(string name) {
-    exists(AssocTypeArg arg |
-      arg = path.getSegment().getGenericArgList().getAGenericArg() and
-      result = arg.getTypeRepr() and
-      name = arg.getIdentifier().getText()
-    )
-  }
-
-  /** Gets the type argument for the associated type `alias`, if any. */
-  pragma[nomagic]
-  private TypeRepr getAnAssocTypeArgument(TypeAlias alias) {
-    exists(string name |
-      alias = this.getResolvedTraitAlias(name) and
-      result = this.getAssocTypeArg(name)
-    )
-  }
-
-  override TypeMention getMentionAt(TypePath tp) {
-    result = super.getMentionAt(tp)
-    or
-    exists(TypeAlias alias, AssociatedTypeTypeParameter attp, TypeMention arg, TypePath suffix |
-      arg = this.getAnAssocTypeArgument(alias) and
-      result = arg.getMentionAt(suffix) and
-      tp = TypePath::cons(attp, suffix) and
-      attp.getTypeAlias() = alias
-    )
-  }
 }
 
 class ImplTraitTypeReprMention extends TypeMention instanceof ImplTraitTypeRepr {