Refactor Spring test

Author: egregius313

java/ql/test/library-tests/frameworks/spring/controller/test.ql

@@ -2,20 +2,18 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import TestUtilities.InlineFlowTest
 
-class EnableLegacy extends EnableLegacyConfiguration {
-  EnableLegacy() { exists(this) }
-}
-
-class ValueFlowConf extends DataFlow::Configuration {
-  ValueFlowConf() { this = "ValueFlowConf" }
-
-  override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
+module ValueFlowConfig implements DataFlow::ConfigSig {
+  predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
-  override predicate isSink(DataFlow::Node sink) {
+  predicate isSink(DataFlow::Node sink) {
     sink.asExpr().(Argument).getCall().getCallee().hasName("sink")
   }
 }
 
+module ValueFlow = DataFlow::Global<ValueFlowConfig>;
+
 class Test extends InlineFlowTest {
-  override DataFlow::Configuration getValueFlowConfig() { result = any(ValueFlowConf config) }
+  override predicate hasValueFlow(DataFlow::Node src, DataFlow::Node sink) {
+    ValueFlow::flow(src, sink)
+  }
 }