C#: Move all file lookup to separate class

tamasvajk · tamasvajk · commit 5406fac8341c · 2024-04-12T13:58:49.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.Nuget.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.Nuget.cs
@@ -13,15 +13,15 @@ namespace Semmle.Extraction.CSharp.DependencyFetching
 {
     public sealed partial class DependencyManager
     {
-        private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<string> allProjects, IEnumerable<string> allSolutions, HashSet<AssemblyLookupLocation> dllLocations)
+        private void RestoreNugetPackages(HashSet<AssemblyLookupLocation> dllLocations)
         {
             var checkNugetFeedResponsiveness = EnvironmentVariables.GetBoolean(EnvironmentVariableNames.CheckNugetFeedResponsiveness);
             try
             {
-                if (checkNugetFeedResponsiveness && !CheckFeeds(allNonBinaryFiles))
+                if (checkNugetFeedResponsiveness && !CheckFeeds())
                 {
                     // todo: we could also check the reachability of the inherited nuget feeds, but to use those in the fallback we would need to handle authentication too.
-                    DownloadMissingPackagesFromSpecificFeeds(allNonBinaryFiles, dllLocations);
+                    DownloadMissingPackagesFromSpecificFeeds(dllLocations);
                     return;
                 }
 
@@ -64,8 +64,8 @@ private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<
                 logger.LogError($"Failed to restore Nuget packages with nuget.exe: {exc.Message}");
             }
 
-            var restoredProjects = RestoreSolutions(allSolutions, out var assets1);
-            var projects = allProjects.Except(restoredProjects);
+            var restoredProjects = RestoreSolutions(out var assets1);
+            var projects = fileProvider.Projects.Except(restoredProjects);
             RestoreProjects(projects, out var assets2);
 
             var dependencies = Assets.GetCompilationDependencies(logger, assets1.Union(assets2));
@@ -80,11 +80,11 @@ private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<
 
             if (checkNugetFeedResponsiveness)
             {
-                DownloadMissingPackagesFromSpecificFeeds(allNonBinaryFiles, dllLocations);
+                DownloadMissingPackagesFromSpecificFeeds(dllLocations);
             }
             else
             {
-                DownloadMissingPackages(allNonBinaryFiles, dllLocations);
+                DownloadMissingPackages(dllLocations);
             }
         }
 
@@ -122,13 +122,12 @@ private List<string> GetReachableFallbackNugetFeeds()
         /// Populates assets with the relative paths to the assets files generated by the restore.
         /// Returns a list of projects that are up to date with respect to restore.
         /// </summary>
-        /// <param name="solutions">A list of paths to solution files.</param>
-        private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out IEnumerable<string> assets)
+        private IEnumerable<string> RestoreSolutions(out IEnumerable<string> assets)
         {
             var successCount = 0;
             var nugetSourceFailures = 0;
             var assetFiles = new List<string>();
-            var projects = solutions.SelectMany(solution =>
+            var projects = fileProvider.Solutions.SelectMany(solution =>
                 {
                     logger.LogInfo($"Restoring solution {solution}...");
                     var res = dotnet.Restore(new(solution, packageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true));
@@ -184,20 +183,20 @@ private void RestoreProjects(IEnumerable<string> projects, out IEnumerable<strin
             CompilationInfos.Add(("Failed project restore with package source error", nugetSourceFailures.ToString()));
         }
 
-        private void DownloadMissingPackagesFromSpecificFeeds(List<FileInfo> allNonBinaryFiles, HashSet<AssemblyLookupLocation> dllLocations)
+        private void DownloadMissingPackagesFromSpecificFeeds(HashSet<AssemblyLookupLocation> dllLocations)
         {
             var reachableFallbackFeeds = GetReachableFallbackNugetFeeds();
             if (reachableFallbackFeeds.Count > 0)
             {
-                DownloadMissingPackages(allNonBinaryFiles, dllLocations, fallbackNugetFeeds: reachableFallbackFeeds);
+                DownloadMissingPackages(dllLocations, fallbackNugetFeeds: reachableFallbackFeeds);
             }
             else
             {
                 logger.LogWarning("Skipping download of missing packages from specific feeds as no fallback Nuget feeds are reachable.");
             }
         }
 
-        private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLookupLocation> dllLocations, IEnumerable<string>? fallbackNugetFeeds = null)
+        private void DownloadMissingPackages(HashSet<AssemblyLookupLocation> dllLocations, IEnumerable<string>? fallbackNugetFeeds = null)
         {
             var alreadyDownloadedPackages = GetRestoredPackageDirectoryNames(packageDirectory.DirInfo);
             var alreadyDownloadedLegacyPackages = GetRestoredLegacyPackageNames();
@@ -232,7 +231,7 @@ private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLo
             logger.LogInfo($"Found {notYetDownloadedPackages.Count} packages that are not yet restored");
             using var tempDir = new TemporaryDirectory(ComputeTempDirectory(sourceDir.FullName, "nugetconfig"));
             var nugetConfig = fallbackNugetFeeds is null
-                ? GetNugetConfig(allFiles)
+                ? GetNugetConfig()
                 : CreateFallbackNugetConfig(fallbackNugetFeeds, tempDir.DirInfo.FullName);
 
             CompilationInfos.Add(("Fallback nuget restore", notYetDownloadedPackages.Count.ToString()));
@@ -280,19 +279,14 @@ private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLo
             return nugetConfigPath;
         }
 
-        private string[] GetAllNugetConfigs(List<FileInfo> allFiles) => allFiles.SelectFileNamesByName("nuget.config").ToArray();
-
-        private string? GetNugetConfig(List<FileInfo> allFiles)
+        private string? GetNugetConfig()
         {
-            var nugetConfigs = GetAllNugetConfigs(allFiles);
+            var nugetConfigs = fileProvider.NugetConfigs;
             string? nugetConfig;
-            if (nugetConfigs.Length > 1)
+            if (nugetConfigs.Count > 1)
             {
                 logger.LogInfo($"Found multiple nuget.config files: {string.Join(", ", nugetConfigs)}.");
-                nugetConfig = allFiles
-                    .SelectRootFiles(sourceDir)
-                    .SelectFileNamesByName("nuget.config")
-                    .FirstOrDefault();
+                nugetConfig = fileProvider.RootNugetConfig;
                 if (nugetConfig == null)
                 {
                     logger.LogInfo("Could not find a top-level nuget.config file.");
@@ -512,10 +506,10 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,
             return (timeoutMilliSeconds, tryCount);
         }
 
-        private bool CheckFeeds(List<FileInfo> allFiles)
+        private bool CheckFeeds()
         {
             logger.LogInfo("Checking Nuget feeds...");
-            var (explicitFeeds, allFeeds) = GetAllFeeds(allFiles);
+            var (explicitFeeds, allFeeds) = GetAllFeeds();
 
             var excludedFeeds = EnvironmentVariables.GetURLs(EnvironmentVariableNames.ExcludedNugetFeedsFromResponsivenessCheck)
                 .ToHashSet() ?? [];
@@ -581,13 +575,13 @@ private IEnumerable<string> GetFeeds(Func<IList<string>> getNugetFeeds)
             }
         }
 
-        private (HashSet<string> explicitFeeds, HashSet<string> allFeeds) GetAllFeeds(List<FileInfo> allFiles)
+        private (HashSet<string> explicitFeeds, HashSet<string> allFeeds) GetAllFeeds()
         {
             IList<string> GetNugetFeeds(string nugetConfig) => dotnet.GetNugetFeeds(nugetConfig);
 
             IList<string> GetNugetFeedsFromFolder(string folderPath) => dotnet.GetNugetFeedsFromFolder(folderPath);
 
-            var nugetConfigs = GetAllNugetConfigs(allFiles);
+            var nugetConfigs = fileProvider.NugetConfigs;
             var explicitFeeds = nugetConfigs
                 .SelectMany(config => GetFeeds(() => GetNugetFeeds(config)))
                 .ToHashSet();
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs
@@ -36,6 +36,7 @@ public sealed partial class DependencyManager : IDisposable
         private readonly TemporaryDirectory legacyPackageDirectory;
         private readonly TemporaryDirectory missingPackageDirectory;
         private readonly TemporaryDirectory tempWorkingDirectory;
+        private readonly FileProvider fileProvider;
         private readonly bool cleanupTempWorkingDirectory;
 
         private readonly Lazy<Runtime> runtimeLazy;
@@ -79,20 +80,10 @@ public DependencyManager(string srcDir, ILogger logger)
 
             tempWorkingDirectory = new TemporaryDirectory(FileUtils.GetTemporaryWorkingDirectory(out cleanupTempWorkingDirectory));
 
-            logger.LogInfo($"Finding files in {srcDir}...");
-
-            var allFiles = GetAllFiles().ToList();
-            var binaryFileExtensions = new HashSet<string>(new[] { ".dll", ".exe" }); // TODO: add more binary file extensions.
-            var allNonBinaryFiles = allFiles.Where(f => !binaryFileExtensions.Contains(f.Extension.ToLowerInvariant())).ToList();
-            var smallNonBinaryFiles = allNonBinaryFiles.SelectSmallFiles(logger).SelectFileNames().ToList();
-            this.fileContent = new FileContent(logger, smallNonBinaryFiles);
-            this.nonGeneratedSources = allNonBinaryFiles.SelectFileNamesByExtension(".cs").ToList();
-            this.generatedSources = new();
-            var allProjects = allNonBinaryFiles.SelectFileNamesByExtension(".csproj").ToList();
-            var allSolutions = allNonBinaryFiles.SelectFileNamesByExtension(".sln").ToList();
-            var dllLocations = allFiles.SelectFileNamesByExtension(".dll").Select(x => new AssemblyLookupLocation(x)).ToHashSet();
-
-            logger.LogInfo($"Found {allFiles.Count} files, {nonGeneratedSources.Count} source files, {allProjects.Count} project files, {allSolutions.Count} solution files, {dllLocations.Count} DLLs.");
+            this.fileProvider = new FileProvider(sourceDir, logger);
+            this.fileContent = new FileContent(logger, this.fileProvider.SmallNonBinary);
+            this.nonGeneratedSources = fileProvider.Sources.ToList();
+            this.generatedSources = [];
 
             void startCallback(string s, bool silent)
             {
@@ -104,7 +95,7 @@ void exitCallback(int ret, string msg, bool silent)
                 logger.Log(silent ? Severity.Debug : Severity.Info, $"Exit code {ret}{(string.IsNullOrEmpty(msg) ? "" : $": {msg}")}");
             }
 
-            DotNet.WithDotNet(SystemBuildActions.Instance, logger, smallNonBinaryFiles, tempWorkingDirectory.ToString(), shouldCleanUp: false, ensureDotNetAvailable: true, version: null, installDir =>
+            DotNet.WithDotNet(SystemBuildActions.Instance, logger, fileProvider.GlobalJsons, tempWorkingDirectory.ToString(), shouldCleanUp: false, ensureDotNetAvailable: true, version: null, installDir =>
             {
                 this.dotnetPath = installDir;
                 return BuildScript.Success;
@@ -121,13 +112,14 @@ void exitCallback(int ret, string msg, bool silent)
                 throw;
             }
 
-            RestoreNugetPackages(allNonBinaryFiles, allProjects, allSolutions, dllLocations);
+            var dllLocations = fileProvider.Dlls.Select(x => new AssemblyLookupLocation(x)).ToHashSet();
+            RestoreNugetPackages(dllLocations);
             // Find DLLs in the .Net / Asp.Net Framework
             // This needs to come after the nuget restore, because the nuget restore might fetch the .NET Core/Framework reference assemblies.
             var frameworkLocations = AddFrameworkDlls(dllLocations);
 
             assemblyCache = new AssemblyCache(dllLocations, frameworkLocations, logger);
-            AnalyseSolutions(allSolutions);
+            AnalyseSolutions(fileProvider.Solutions);
 
             foreach (var filename in assemblyCache.AllAssemblies.Select(a => a.Filename))
             {
@@ -154,7 +146,7 @@ void exitCallback(int ret, string msg, bool silent)
                 shouldExtractWebViews)
             {
                 CompilationInfos.Add(("WebView extraction enabled", "1"));
-                GenerateSourceFilesFromWebViews(allNonBinaryFiles);
+                GenerateSourceFilesFromWebViews();
             }
             else
             {
@@ -171,8 +163,8 @@ void exitCallback(int ret, string msg, bool silent)
             logger.LogInfo("Build analysis summary:");
             logger.LogInfo($"{nonGeneratedSources.Count,align} source files found on the filesystem");
             logger.LogInfo($"{generatedSources.Count,align} source files have been generated");
-            logger.LogInfo($"{allSolutions.Count,align} solution files found on the filesystem");
-            logger.LogInfo($"{allProjects.Count,align} project files found on the filesystem");
+            logger.LogInfo($"{fileProvider.Solutions.Count,align} solution files found on the filesystem");
+            logger.LogInfo($"{fileProvider.Projects.Count,align} project files found on the filesystem");
             logger.LogInfo($"{usedReferences.Keys.Count,align} resolved references");
             logger.LogInfo($"{unresolvedReferences.Count,align} unresolved references");
             logger.LogInfo($"{conflictedReferences,align} resolved assembly conflicts");
@@ -182,8 +174,8 @@ void exitCallback(int ret, string msg, bool silent)
             CompilationInfos.AddRange([
                 ("Source files on filesystem", nonGeneratedSources.Count.ToString()),
                 ("Source files generated", generatedSources.Count.ToString()),
-                ("Solution files on filesystem", allSolutions.Count.ToString()),
-                ("Project files on filesystem", allProjects.Count.ToString()),
+                ("Solution files on filesystem", fileProvider.Solutions.Count.ToString()),
+                ("Project files on filesystem", fileProvider.Projects.Count.ToString()),
                 ("Resolved references", usedReferences.Keys.Count.ToString()),
                 ("Unresolved references", unresolvedReferences.Count.ToString()),
                 ("Resolved assembly conflicts", conflictedReferences.ToString()),
@@ -467,15 +459,15 @@ private void GenerateSourceFileFromImplicitUsings()
             }
         }
 
-        private void GenerateSourceFilesFromWebViews(List<FileInfo> allFiles)
+        private void GenerateSourceFilesFromWebViews()
         {
-            var views = allFiles.SelectFileNamesByExtension(".cshtml", ".razor").ToArray();
-            if (views.Length == 0)
+            var views = fileProvider.RazorViews;
+            if (views.Count == 0)
             {
                 return;
             }
 
-            logger.LogInfo($"Found {views.Length} cshtml and razor files.");
+            logger.LogInfo($"Found {views.Count} cshtml and razor files.");
 
             if (!IsAspNetCoreDetected())
             {
@@ -503,38 +495,6 @@ private void GenerateSourceFilesFromWebViews(List<FileInfo> allFiles)
             }
         }
 
-        private IEnumerable<FileInfo> GetAllFiles()
-        {
-            IEnumerable<FileInfo> files = sourceDir.GetFiles("*.*", new EnumerationOptions { RecurseSubdirectories = true });
-
-            if (dotnetPath != null)
-            {
-                files = files.Where(f => !f.FullName.StartsWith(dotnetPath, StringComparison.OrdinalIgnoreCase));
-            }
-
-            files = files.Where(f =>
-            {
-                try
-                {
-                    if (f.Exists)
-                    {
-                        return true;
-                    }
-
-                    logger.LogWarning($"File {f.FullName} could not be processed.");
-                    return false;
-                }
-                catch (Exception ex)
-                {
-                    logger.LogWarning($"File {f.FullName} could not be processed: {ex.Message}");
-                    return false;
-                }
-            });
-
-            files = new FilePathFilter(sourceDir, logger).Filter(files);
-            return files;
-        }
-
         /// <summary>
         /// Computes a unique temp directory for the packages associated
         /// with this source tree. Use a SHA1 of the directory name.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileInfoExtensions.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileInfoExtensions.cs
@@ -14,20 +14,6 @@ private static IEnumerable<string> SelectFilesAux(this IEnumerable<FileInfo> fil
         public static IEnumerable<FileInfo> SelectRootFiles(this IEnumerable<FileInfo> files, DirectoryInfo dir) =>
             files.Where(file => file.DirectoryName == dir.FullName);
 
-        internal static IEnumerable<FileInfo> SelectSmallFiles(this IEnumerable<FileInfo> files, ILogger logger)
-        {
-            const int oneMb = 1_048_576;
-            return files.Where(file =>
-            {
-                if (file.Length > oneMb)
-                {
-                    logger.LogDebug($"Skipping {file.FullName} because it is bigger than 1MB.");
-                    return false;
-                }
-                return true;
-            });
-        }
-
         public static IEnumerable<string> SelectFileNamesByExtension(this IEnumerable<FileInfo> files, params string[] extensions) =>
             files.SelectFilesAux(fi => extensions.Contains(fi.Extension));
 
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileProvider.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileProvider.cs

Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,15 @@ namespace Semmle.Extraction.CSharp.DependencyFetching`
`13`	`13`	`{`
`14`	`14`	`public sealed partial class DependencyManager`
`15`	`15`	`{`
`16`		`- private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<string> allProjects, IEnumerable<string> allSolutions, HashSet<AssemblyLookupLocation> dllLocations)`
	`16`	`+ private void RestoreNugetPackages(HashSet<AssemblyLookupLocation> dllLocations)`
`17`	`17`	`{`
`18`	`18`	`var checkNugetFeedResponsiveness = EnvironmentVariables.GetBoolean(EnvironmentVariableNames.CheckNugetFeedResponsiveness);`
`19`	`19`	`try`
`20`	`20`	`{`
`21`		`- if (checkNugetFeedResponsiveness && !CheckFeeds(allNonBinaryFiles))`
	`21`	`+ if (checkNugetFeedResponsiveness && !CheckFeeds())`
`22`	`22`	`{`
`23`	`23`	`// todo: we could also check the reachability of the inherited nuget feeds, but to use those in the fallback we would need to handle authentication too.`
`24`		`- DownloadMissingPackagesFromSpecificFeeds(allNonBinaryFiles, dllLocations);`
	`24`	`+ DownloadMissingPackagesFromSpecificFeeds(dllLocations);`
`25`	`25`	`return;`
`26`	`26`	`}`
`27`	`27`
`@@ -64,8 +64,8 @@ private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<`
`64`	`64`	`logger.LogError($"Failed to restore Nuget packages with nuget.exe: {exc.Message}");`
`65`	`65`	`}`
`66`	`66`
`67`		`- var restoredProjects = RestoreSolutions(allSolutions, out var assets1);`
`68`		`- var projects = allProjects.Except(restoredProjects);`
	`67`	`+ var restoredProjects = RestoreSolutions(out var assets1);`
	`68`	`+ var projects = fileProvider.Projects.Except(restoredProjects);`
`69`	`69`	`RestoreProjects(projects, out var assets2);`
`70`	`70`
`71`	`71`	`var dependencies = Assets.GetCompilationDependencies(logger, assets1.Union(assets2));`
`@@ -80,11 +80,11 @@ private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<`
`80`	`80`
`81`	`81`	`if (checkNugetFeedResponsiveness)`
`82`	`82`	`{`
`83`		`- DownloadMissingPackagesFromSpecificFeeds(allNonBinaryFiles, dllLocations);`
	`83`	`+ DownloadMissingPackagesFromSpecificFeeds(dllLocations);`
`84`	`84`	`}`
`85`	`85`	`else`
`86`	`86`	`{`
`87`		`- DownloadMissingPackages(allNonBinaryFiles, dllLocations);`
	`87`	`+ DownloadMissingPackages(dllLocations);`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`
`@@ -122,13 +122,12 @@ private List<string> GetReachableFallbackNugetFeeds()`
`122`	`122`	`/// Populates assets with the relative paths to the assets files generated by the restore.`
`123`	`123`	`/// Returns a list of projects that are up to date with respect to restore.`
`124`	`124`	`/// </summary>`
`125`		`- /// <param name="solutions">A list of paths to solution files.</param>`
`126`		`- private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out IEnumerable<string> assets)`
	`125`	`+ private IEnumerable<string> RestoreSolutions(out IEnumerable<string> assets)`
`127`	`126`	`{`
`128`	`127`	`var successCount = 0;`
`129`	`128`	`var nugetSourceFailures = 0;`
`130`	`129`	`var assetFiles = new List<string>();`
`131`		`- var projects = solutions.SelectMany(solution =>`
	`130`	`+ var projects = fileProvider.Solutions.SelectMany(solution =>`
`132`	`131`	`{`
`133`	`132`	`logger.LogInfo($"Restoring solution {solution}...");`
`134`	`133`	`var res = dotnet.Restore(new(solution, packageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true));`
`@@ -184,20 +183,20 @@ private void RestoreProjects(IEnumerable<string> projects, out IEnumerable<strin`
`184`	`183`	`CompilationInfos.Add(("Failed project restore with package source error", nugetSourceFailures.ToString()));`
`185`	`184`	`}`
`186`	`185`
`187`		`- private void DownloadMissingPackagesFromSpecificFeeds(List<FileInfo> allNonBinaryFiles, HashSet<AssemblyLookupLocation> dllLocations)`
	`186`	`+ private void DownloadMissingPackagesFromSpecificFeeds(HashSet<AssemblyLookupLocation> dllLocations)`
`188`	`187`	`{`
`189`	`188`	`var reachableFallbackFeeds = GetReachableFallbackNugetFeeds();`
`190`	`189`	`if (reachableFallbackFeeds.Count > 0)`
`191`	`190`	`{`
`192`		`- DownloadMissingPackages(allNonBinaryFiles, dllLocations, fallbackNugetFeeds: reachableFallbackFeeds);`
	`191`	`+ DownloadMissingPackages(dllLocations, fallbackNugetFeeds: reachableFallbackFeeds);`
`193`	`192`	`}`
`194`	`193`	`else`
`195`	`194`	`{`
`196`	`195`	`logger.LogWarning("Skipping download of missing packages from specific feeds as no fallback Nuget feeds are reachable.");`
`197`	`196`	`}`
`198`	`197`	`}`
`199`	`198`
`200`		`- private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLookupLocation> dllLocations, IEnumerable<string>? fallbackNugetFeeds = null)`
	`199`	`+ private void DownloadMissingPackages(HashSet<AssemblyLookupLocation> dllLocations, IEnumerable<string>? fallbackNugetFeeds = null)`
`201`	`200`	`{`
`202`	`201`	`var alreadyDownloadedPackages = GetRestoredPackageDirectoryNames(packageDirectory.DirInfo);`
`203`	`202`	`var alreadyDownloadedLegacyPackages = GetRestoredLegacyPackageNames();`
`@@ -232,7 +231,7 @@ private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLo`
`232`	`231`	`logger.LogInfo($"Found {notYetDownloadedPackages.Count} packages that are not yet restored");`
`233`	`232`	`using var tempDir = new TemporaryDirectory(ComputeTempDirectory(sourceDir.FullName, "nugetconfig"));`
`234`	`233`	`var nugetConfig = fallbackNugetFeeds is null`
`235`		`- ? GetNugetConfig(allFiles)`
	`234`	`+ ? GetNugetConfig()`
`236`	`235`	`: CreateFallbackNugetConfig(fallbackNugetFeeds, tempDir.DirInfo.FullName);`
`237`	`236`
`238`	`237`	`CompilationInfos.Add(("Fallback nuget restore", notYetDownloadedPackages.Count.ToString()));`
`@@ -280,19 +279,14 @@ private void DownloadMissingPackages(List<FileInfo> allFiles, HashSet<AssemblyLo`
`280`	`279`	`return nugetConfigPath;`
`281`	`280`	`}`
`282`	`281`
`283`		`- private string[] GetAllNugetConfigs(List<FileInfo> allFiles) => allFiles.SelectFileNamesByName("nuget.config").ToArray();`
`284`		`-`
`285`		`- private string? GetNugetConfig(List<FileInfo> allFiles)`
	`282`	`+ private string? GetNugetConfig()`
`286`	`283`	`{`
`287`		`- var nugetConfigs = GetAllNugetConfigs(allFiles);`
	`284`	`+ var nugetConfigs = fileProvider.NugetConfigs;`
`288`	`285`	`string? nugetConfig;`
`289`		`- if (nugetConfigs.Length > 1)`
	`286`	`+ if (nugetConfigs.Count > 1)`
`290`	`287`	`{`
`291`	`288`	`logger.LogInfo($"Found multiple nuget.config files: {string.Join(", ", nugetConfigs)}.");`
`292`		`- nugetConfig = allFiles`
`293`		`- .SelectRootFiles(sourceDir)`
`294`		`- .SelectFileNamesByName("nuget.config")`
`295`		`- .FirstOrDefault();`
	`289`	`+ nugetConfig = fileProvider.RootNugetConfig;`
`296`	`290`	`if (nugetConfig == null)`
`297`	`291`	`{`
`298`	`292`	`logger.LogInfo("Could not find a top-level nuget.config file.");`
`@@ -512,10 +506,10 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,`
`512`	`506`	`return (timeoutMilliSeconds, tryCount);`
`513`	`507`	`}`
`514`	`508`
`515`		`- private bool CheckFeeds(List<FileInfo> allFiles)`
	`509`	`+ private bool CheckFeeds()`
`516`	`510`	`{`
`517`	`511`	`logger.LogInfo("Checking Nuget feeds...");`
`518`		`- var (explicitFeeds, allFeeds) = GetAllFeeds(allFiles);`
	`512`	`+ var (explicitFeeds, allFeeds) = GetAllFeeds();`
`519`	`513`
`520`	`514`	`var excludedFeeds = EnvironmentVariables.GetURLs(EnvironmentVariableNames.ExcludedNugetFeedsFromResponsivenessCheck)`
`521`	`515`	`.ToHashSet() ?? [];`
`@@ -581,13 +575,13 @@ private IEnumerable<string> GetFeeds(Func<IList<string>> getNugetFeeds)`
`581`	`575`	`}`
`582`	`576`	`}`
`583`	`577`
`584`		`- private (HashSet<string> explicitFeeds, HashSet<string> allFeeds) GetAllFeeds(List<FileInfo> allFiles)`
	`578`	`+ private (HashSet<string> explicitFeeds, HashSet<string> allFeeds) GetAllFeeds()`
`585`	`579`	`{`
`586`	`580`	`IList<string> GetNugetFeeds(string nugetConfig) => dotnet.GetNugetFeeds(nugetConfig);`
`587`	`581`
`588`	`582`	`IList<string> GetNugetFeedsFromFolder(string folderPath) => dotnet.GetNugetFeedsFromFolder(folderPath);`
`589`	`583`
`590`		`- var nugetConfigs = GetAllNugetConfigs(allFiles);`
	`584`	`+ var nugetConfigs = fileProvider.NugetConfigs;`
`591`	`585`	`var explicitFeeds = nugetConfigs`
`592`	`586`	`.SelectMany(config => GetFeeds(() => GetNugetFeeds(config)))`
`593`	`587`	`.ToHashSet();`