JS: Fix location override in CaptureNode

asgerf · asgerf · commit 536c115c1c13 · 2024-05-06T13:51:25.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll
@@ -60,7 +60,7 @@ class CaptureNode extends DataFlow::Node, TSynthCaptureNode {
   override string toString() { result = this.toStringInternal() } // cached in parent class
 
   cached
-  private Location getLocation() { result = this.getNode().getLocation() }
+  override Location getLocation() { result = this.getNode().getLocation() }
 }
 
 class GenericSynthesizedNode extends DataFlow::Node, TGenericSynthesizedNode {

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class CaptureNode extends DataFlow::Node, TSynthCaptureNode {`
`60`	`60`	`override string toString() { result = this.toStringInternal() } // cached in parent class`
`61`	`61`
`62`	`62`	`cached`
`63`		`- private Location getLocation() { result = this.getNode().getLocation() }`
	`63`	`+ override Location getLocation() { result = this.getNode().getLocation() }`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`class GenericSynthesizedNode extends DataFlow::Node, TGenericSynthesizedNode {`