Skip to content

Commit 532a64f

Browse files
committed
C++: Name/description of HResultBooleanConversion
This commit changes the name and description of the new `HResultBooleanConversion` query to follow our internal guidelines.
1 parent d813cb6 commit 532a64f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

cpp/ql/src/Security/CWE/CWE-253/HResultBooleanConversion.ql

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
/**
2-
* @name Cast between semantically different integer types: HRESULT to/from a Boolean type
3-
* @description Cast between semantically different integer types: HRESULT to/from a Boolean type.
4-
* Boolean types indicate success by a non-zero value, whereas success (S_OK) in HRESULT is indicated by a value of 0.
5-
* Casting an HRESULT to/from a Boolean type and then using it in a test expression will yield an incorrect result.
2+
* @name Cast between HRESULT and a Boolean type
3+
* @description Casting an HRESULT to/from a Boolean type and then using it in a test expression will yield an incorrect result because success (S_OK) in HRESULT is indicated by a value of 0.
64
* @kind problem
75
* @id cpp/hresult-boolean-conversion
86
* @problem.severity error
@@ -68,4 +66,4 @@ where exists
6866
)
6967
and not isHresultBooleanConverted(e1)
7068
)
71-
select e1, msg
69+
select e1, msg

0 commit comments

Comments
 (0)