JavaScript: cache AdditionalPartialInvokeNode

asger-semmle · asger-semmle · commit 52c913b3251a · 2018-09-25T10:16:40.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -288,11 +288,11 @@ abstract class AdditionalSink extends DataFlow::Node {
  *
  * This contributes additional argument-passing flow edges that should be added to all data flow configurations.
  */
-abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {
+cached abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {
   /**
    * Holds if `argument` is passed as argument `index` to the function in `callback`.
    */
-  abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);
+  cached abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -288,11 +288,11 @@ abstract class AdditionalSink extends DataFlow::Node {`
`288`	`288`	`*`
`289`	`289`	`* This contributes additional argument-passing flow edges that should be added to all data flow configurations.`
`290`	`290`	`*/`
`291`		`-abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {`
	`291`	`+cached abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {`
`292`	`292`	`/**`
`293`	`293`	* Holds if `argument` is passed as argument `index` to the function in `callback`.
`294`	`294`	`*/`
`295`		`- abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);`
	`295`	`+ cached abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`/**`