JS: Expand support for JSDoc in ES2015 modules

asgerf · asgerf · commit 50420a27a73e · 2025-03-20T14:35:35.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/internal/TypeResolution.qll b/javascript/ql/lib/semmle/javascript/internal/TypeResolution.qll
@@ -155,6 +155,14 @@ module TypeResolution {
       name = spec.getImportedName() and
       node2 = spec.getLocal()
     )
+    or
+    // Support JSDoc expressions of the form 'foo.bar' where 'foo' is an import
+    // at the top-level.
+    exists(JSDocNamedTypeExpr expr, string prefix |
+      expr.hasNameParts(prefix, name) and
+      node1 = expr.getTopLevel().getScope().getVariable(prefix) and
+      node2 = expr
+    )
   }
 
   private signature module TypeResolutionInputSig {

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,14 @@ module TypeResolution {`
`155`	`155`	`name = spec.getImportedName() and`
`156`	`156`	`node2 = spec.getLocal()`
`157`	`157`	`)`
	`158`	`+ or`
	`159`	`+ // Support JSDoc expressions of the form 'foo.bar' where 'foo' is an import`
	`160`	`+ // at the top-level.`
	`161`	`+ exists(JSDocNamedTypeExpr expr, string prefix \|`
	`162`	`+ expr.hasNameParts(prefix, name) and`
	`163`	`+ node1 = expr.getTopLevel().getScope().getVariable(prefix) and`
	`164`	`+ node2 = expr`
	`165`	`+ )`
`158`	`166`	`}`
`159`	`167`
`160`	`168`	`private signature module TypeResolutionInputSig {`