JavaScript: do not cache AdditionalPartialInvokeNode

asger-semmle · asger-semmle · commit 4e7f171f54b0 · 2018-10-10T09:40:49.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -359,11 +359,11 @@ abstract class AdditionalSink extends DataFlow::Node {
  *
  * This contributes additional argument-passing flow edges that should be added to all data flow configurations.
  */
-cached abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {
+abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {
   /**
    * Holds if `argument` is passed as argument `index` to the function in `callback`.
    */
-  cached abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);
+  abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -359,11 +359,11 @@ abstract class AdditionalSink extends DataFlow::Node {`
`359`	`359`	`*`
`360`	`360`	`* This contributes additional argument-passing flow edges that should be added to all data flow configurations.`
`361`	`361`	`*/`
`362`		`-cached abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {`
	`362`	`+abstract class AdditionalPartialInvokeNode extends DataFlow::InvokeNode {`
`363`	`363`	`/**`
`364`	`364`	* Holds if `argument` is passed as argument `index` to the function in `callback`.
`365`	`365`	`*/`
`366`		`- cached abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);`
	`366`	`+ abstract predicate isPartialArgument(DataFlow::Node callback, DataFlow::Node argument, int index);`
`367`	`367`	`}`
`368`	`368`
`369`	`369`	`/**`