Fix missed case

smowton · smowton · commit 4da5cd9bd094 · 2024-09-02T15:04:56.000+01:00
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll
@@ -158,7 +158,7 @@ predicate storeStep(Node node1, ContentSet c, Node node2) {
   )
   or
   node1 = node2.(AddressOperationNode).getOperand() and
-  c = any(DataFlow::PointerContent pc | pc.getPointerType() = node2.getType())
+  c = any(DataFlow::PointerContent pc | pc.getPointerType() = node2.getType().getDeepUnaliasedType())
   or
   FlowSummaryImpl::Private::Steps::summaryStoreStep(node1.(FlowSummaryNode).getSummaryNode(), c,
     node2.(FlowSummaryNode).getSummaryNode())

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ predicate storeStep(Node node1, ContentSet c, Node node2) {`
`158`	`158`	`)`
`159`	`159`	`or`
`160`	`160`	`node1 = node2.(AddressOperationNode).getOperand() and`
`161`		`- c = any(DataFlow::PointerContent pc \| pc.getPointerType() = node2.getType())`
	`161`	`+ c = any(DataFlow::PointerContent pc \| pc.getPointerType() = node2.getType().getDeepUnaliasedType())`
`162`	`162`	`or`
`163`	`163`	`FlowSummaryImpl::Private::Steps::summaryStoreStep(node1.(FlowSummaryNode).getSummaryNode(), c,`
`164`	`164`	`node2.(FlowSummaryNode).getSummaryNode())`