Skip to content

Commit 477be26

Browse files
committed
JS: rename UselessRangeCheck -> UselessComparisonTest
1 parent 2e65f6b commit 477be26

File tree

9 files changed

+6
-5
lines changed

9 files changed

+6
-5
lines changed

javascript/ql/src/Statements/UselessRangeCheck.qhelp renamed to javascript/ql/src/Statements/UselessComparisonTest.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ If the check is needed to guard against <code>NaN</code> values, insert a commen
2727
The following example finds the index of an element in a given slice of the array:
2828
</p>
2929

30-
<sample src="examples/UselessRangeCheck.js" />
30+
<sample src="examples/UselessComparisonTest.js" />
3131

3232
<p>
3333
The condition <code>i &lt; end</code> at the end is always false, however. The code can be clarified if the
3434
redundant condition is removed:
3535
</p>
3636

37-
<sample src="examples/UselessRangeCheckGood.js" />
37+
<sample src="examples/UselessComparisonTestGood.js" />
3838

3939
</example>
4040
<references>

javascript/ql/src/Statements/UselessRangeCheck.ql renamed to javascript/ql/src/Statements/UselessComparisonTest.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/**
2-
* @name Useless range check
3-
* @description If a range check always fails or always succeeds, it is indicative of a bug.
2+
* @name Useless comparison test
3+
* @description A comparison that always evaluates to true or always evaluates to false may
4+
* indicate faulty logic and dead code.
45
* @kind problem
56
* @problem.severity warning
67
* @id js/useless-range-check

javascript/ql/src/Statements/examples/UselessRangeCheck.js renamed to javascript/ql/src/Statements/examples/UselessComparisonTest.js

File renamed without changes.

javascript/ql/src/Statements/examples/UselessRangeCheckGood.js renamed to javascript/ql/src/Statements/examples/UselessComparisonTestGood.js

File renamed without changes.

javascript/ql/test/query-tests/Statements/UselessRangeCheck/UselessRangeCheck.expected renamed to javascript/ql/test/query-tests/Statements/UselessComparisonTest/UselessComparisonTest.expected

File renamed without changes.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Statements/UselessComparisonTest.ql

javascript/ql/test/query-tests/Statements/UselessRangeCheck/example.js renamed to javascript/ql/test/query-tests/Statements/UselessComparisonTest/example.js

File renamed without changes.

javascript/ql/test/query-tests/Statements/UselessRangeCheck/exampleGood.js renamed to javascript/ql/test/query-tests/Statements/UselessComparisonTest/exampleGood.js

File renamed without changes.

javascript/ql/test/query-tests/Statements/UselessRangeCheck/UselessRangeCheck.qlref

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)