JS: Mark alert as missing (revert an earlier change in UnsafeShellCommandConstruction)

asgerf · asgerf · commit 461a9438df87 · 2025-02-26T13:14:51.000+01:00
diff --git a/javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/lib.js b/javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/lib.js
@@ -363,7 +363,7 @@ function MyTrainer(opts) {
 
 MyTrainer.prototype = {
 	train: function() {
-		var command = "learn " + this.learn_args + " " + model; // $ Alert
+		var command = "learn " + this.learn_args + " " + model; // $ MISSING: Alert - lack of local field step
 		cp.exec(command);
 	}
 };

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,7 @@ function MyTrainer(opts) {`
`363`	`363`
`364`	`364`	`MyTrainer.prototype = {`
`365`	`365`	`train: function() {`
`366`		`- var command = "learn " + this.learn_args + " " + model; // $ Alert`
	`366`	`+ var command = "learn " + this.learn_args + " " + model; // $ MISSING: Alert - lack of local field step`
`367`	`367`	`cp.exec(command);`
`368`	`368`	`}`
`369`	`369`	`};`