Add default for hasOptionalResult

Author: jketema

cpp/ql/test/library-tests/dataflow/dataflow-tests/has-parameter-flow-out.ql

@@ -19,10 +19,6 @@ module AstTest {
         value = p.getName()
       )
     }
-
-    predicate hasOptionalResult(Location location, string element, string tag, string value) {
-      none()
-    }
   }
 }
 
@@ -49,10 +45,6 @@ module IRTest {
         value = stars(n.getIndirectionIndex()) + p.getName()
       )
     }
-
-    predicate hasOptionalResult(Location location, string element, string tag, string value) {
-      none()
-    }
   }
 }
 

cpp/ql/test/library-tests/dataflow/source-sink-tests/local-flow.ql

@@ -27,10 +27,6 @@ module LocalFlowSourceTest implements TestSig {
       element = node.toString()
     )
   }
-
-  predicate hasOptionalResult(Location location, string element, string tag, string value) {
-    none()
-  }
 }
 
 import MakeTest<LocalFlowSourceTest>

shared/util/codeql/util/test/InlineExpectationsTest.qll

@@ -156,7 +156,11 @@ module Make<InlineExpectationsTestSig Impl> {
      * A failure will still arise if there is an annotation that does not match any results, but not vice versa.
      * Override this predicate to specify optional results.
      */
-    predicate hasOptionalResult(Impl::Location location, string element, string tag, string value);
+    default predicate hasOptionalResult(
+      Impl::Location location, string element, string tag, string value
+    ) {
+      none()
+    }
   }
 
   /**