Skip to content

Commit 3db3e62

Browse files
committed
JS: Temporarily accept a spurious alert
This was due to a bug that will be fixed in the following commit
1 parent 766d07b commit 3db3e62

File tree

1 file changed

+1
-1
lines changed
  • javascript/ql/test/query-tests/Security/CWE-601/ServerSideUrlRedirect

1 file changed

+1
-1
lines changed

javascript/ql/test/query-tests/Security/CWE-601/ServerSideUrlRedirect/express.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ app.get('/some/path', function(req, res) {
2525
var target = req.param("target");
2626
if (isLocalURL(target))
2727
// OK - request parameter is sanitized before incorporating it into the redirect
28-
res.redirect(target);
28+
res.redirect(target); // $ SPURIOUS: Alert
2929
else
3030
res.redirect(target); // $ Alert - sanitization doesn't apply here
3131
res.redirect(target); // $ Alert - sanitization doesn't apply here

0 commit comments

Comments
 (0)