Swift: Add Type.getName().

Author: geoffw0

swift/ql/lib/codeql/swift/elements/type/Type.qll

@@ -2,4 +2,6 @@ private import codeql.swift.generated.type.Type
 
 class Type extends TypeBase {
   override string toString() { result = this.getDiagnosticsName() }
+
+  string getName() { result = this.getDiagnosticsName() }
 }

swift/ql/src/queries/Security/CWE-135/StringLengthConflation.ql

@@ -20,7 +20,7 @@ class StringLengthConflationConfiguration extends DataFlow::Configuration {
   override predicate isSource(DataFlow::Node node, string flowstate) {
     // result of a call to to `String.count`
     exists(MemberRefExpr member |
-      member.getBaseExpr().getType().toString() = "String" and // TODO: use of toString
+      member.getBaseExpr().getType().getName() = "String" and
       member.getMember().toString() = "count" and // TODO: use of toString
       node.asExpr() = member and
       flowstate = "String"