Merge pull request #2995 from tausbn/python-fix-nested-sequence-assign-cp

semmle-qlci · web-flow · commit 3ae1aada372b · 2020-03-06T09:43:24.000Z
Approved by RasmusWL
diff --git a/python/ql/src/semmle/python/Flow.qll b/python/ql/src/semmle/python/Flow.qll
@@ -910,6 +910,10 @@ private AstNode assigned_value(Expr lhs) {
 
 predicate nested_sequence_assign(Expr left_parent, Expr right_parent,
         Expr left_result, Expr right_result) {
+    exists(Assign a |
+        a.getATarget().getASubExpression*() = left_parent and
+        a.getValue().getASubExpression*() = right_parent
+    ) and
     exists(int i, Expr left_elem, Expr right_elem
     |
         (

Original file line number	Diff line number	Diff line change
`@@ -910,6 +910,10 @@ private AstNode assigned_value(Expr lhs) {`
`910`	`910`
`911`	`911`	`predicate nested_sequence_assign(Expr left_parent, Expr right_parent,`
`912`	`912`	`Expr left_result, Expr right_result) {`
	`913`	`+ exists(Assign a \|`
	`914`	`+ a.getATarget().getASubExpression*() = left_parent and`
	`915`	`+ a.getValue().getASubExpression*() = right_parent`
	`916`	`+ ) and`
`913`	`917`	`exists(int i, Expr left_elem, Expr right_elem`
`914`	`918`	`\|`
`915`	`919`	`(`