Add failing test showcasing problem

owen-mc · owen-mc · commit 39eeed92382d · 2023-10-26T10:20:27.000+01:00
diff --git a/go/ql/test/query-tests/Security/CWE-681/IncorrectIntegerConversion.go b/go/ql/test/query-tests/Security/CWE-681/IncorrectIntegerConversion.go
@@ -349,6 +349,15 @@ func testBoundsChecking(input string) {
 	}
 }
 
+func testBoundsChecking2(input string) error {
+	version, err := strconv.ParseUint(input, 10, 0)
+	if err != nil || version > math.MaxInt {
+		return fmt.Errorf("checksum has invalid version: %w", err)
+	}
+	_ = int(version)
+	return nil
+}
+
 func testRightShifted(input string) {
 	{
 		parsed, err := strconv.ParseInt(input, 10, 32)

Original file line number	Diff line number	Diff line change
`@@ -349,6 +349,15 @@ func testBoundsChecking(input string) {`
`349`	`349`	`}`
`350`	`350`	`}`
`351`	`351`
	`352`	`+func testBoundsChecking2(input string) error {`
	`353`	`+ version, err := strconv.ParseUint(input, 10, 0)`
	`354`	`+ if err != nil \|\| version > math.MaxInt {`
	`355`	`+ return fmt.Errorf("checksum has invalid version: %w", err)`
	`356`	`+ }`
	`357`	`+ _ = int(version)`
	`358`	`+ return nil`
	`359`	`+}`
	`360`	`+`
`352`	`361`	`func testRightShifted(input string) {`
`353`	`362`	`{`
`354`	`363`	`parsed, err := strconv.ParseInt(input, 10, 32)`