C++: Don't use dbtypes in Declaration.qll

Author: jbj

cpp/ql/src/semmle/code/cpp/Declaration.qll

@@ -309,7 +309,7 @@ abstract class AccessHolder extends Declaration {
     isDirectPublicBaseOf*(base, derived)
     or
     exists(DirectAccessHolder n |
-      this.getEnclosingAccessHolder*() = mkElement(n) and
+      this.getEnclosingAccessHolder*() = n and
       // Derivations using (4.2) or (4.3) at least once.
       n.thisCanAccessClassTrans(base, derived)
     )
@@ -379,7 +379,7 @@ abstract class AccessHolder extends Declaration {
     everyoneCouldAccessMember(memberClass, memberAccess, derived)
     or
     exists(DirectAccessHolder n |
-      this.getEnclosingAccessHolder*() = mkElement(n) and
+      this.getEnclosingAccessHolder*() = n and
       // Any other derivation.
       n.thisCouldAccessMember(memberClass, memberAccess, derived)
     )
@@ -396,11 +396,11 @@ abstract class AccessHolder extends Declaration {
  * `DirectAccessHolder`s. If a `DirectAccessHolder` contains an `AccessHolder`,
  * then the contained `AccessHolder` inherits its access rights.
  */
-private class DirectAccessHolder extends @declaration {
+private class DirectAccessHolder extends Element {
   DirectAccessHolder() {
-    mkElement(this) instanceof Class
+    this instanceof Class
     or
-    exists(FriendDecl fd | fd.getFriend() = mkElement(this))
+    exists(FriendDecl fd | fd.getFriend() = this)
   }
 
   /**
@@ -486,7 +486,7 @@ private class DirectAccessHolder extends @declaration {
     )
     or
     // Rule (5.4) followed by Rule (5.2)
-    exists(Class between | mkElement(this).(AccessHolder).canAccessClass(between, derived) |
+    exists(Class between | this.(AccessHolder).canAccessClass(between, derived) |
         between.accessOfBaseMember(memberClass, memberAccess)
                .hasName("private") and
         this.isFriendOfOrEqualTo(between)
@@ -539,12 +539,10 @@ private class DirectAccessHolder extends @declaration {
   }
 
   private predicate isFriendOfOrEqualTo(Class c) {
-    exists(FriendDecl fd | fd.getDeclaringClass() = c | mkElement(this) = fd.getFriend())
+    exists(FriendDecl fd | fd.getDeclaringClass() = c | this = fd.getFriend())
     or
-    mkElement(this) = c
+    this = c
   }
-
-  string toString() { result = mkElement(this).(Declaration).toString() }
 }
 
 /**

cpp/ql/test/library-tests/typedefs/Typedefs2.expected

@@ -1,2 +1,2 @@
 | typedefs.cpp:6:6:6:7 | f1 | typedefs.cpp:8:15:8:18 | TYPE | LocalTypedefType |
-| typedefs.cpp:6:6:6:7 | f1 | typedefs.cpp:9:9:9:9 | D | LocalClass, MetricClass, StructLikeClass |
+| typedefs.cpp:6:6:6:7 | f1 | typedefs.cpp:9:9:9:9 | D | DirectAccessHolder, LocalClass, MetricClass, StructLikeClass |

cpp/ql/test/library-tests/variables/variables/types.expected

@@ -18,9 +18,9 @@
 | _Imaginary long double | FloatingPointType |  |  |  |  |
 | __float128 | Float128Type |  |  |  |  |
 | __int128 | Int128Type |  |  |  |  |
-| __va_list_tag | MetricClass, Struct, StructLikeClass |  |  |  |  |
+| __va_list_tag | DirectAccessHolder, MetricClass, Struct, StructLikeClass |  |  |  |  |
 | __va_list_tag & | LValueReferenceType |  | __va_list_tag |  |  |
-| address | MetricClass, Struct, StructLikeClass |  |  |  |  |
+| address | DirectAccessHolder, MetricClass, Struct, StructLikeClass |  |  |  |  |
 | address & | LValueReferenceType |  | address |  |  |
 | address && | RValueReferenceType |  | address |  |  |
 | auto | AutoType |  |  |  |  |