Skip to content

Commit 38534a6

Browse files
author
Max Schaefer
committed
JavaScript: Address review comment.
1 parent 34b33ca commit 38534a6

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

javascript/ql/src/semmle/javascript/BasicBlocks.qll

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,25 +67,25 @@ private cached module Internal {
6767
}
6868

6969
cached predicate defAt(BasicBlock bb, int i, Variable v, VarDef d) {
70-
exists (VarRef def |
71-
def = d.getTarget().(BindingPattern).getABindingVarRef() and
72-
v = def.getVariable() |
73-
def = d.getTarget() and
70+
exists (VarRef lhs |
71+
lhs = d.getTarget().(BindingPattern).getABindingVarRef() and
72+
v = lhs.getVariable() |
73+
lhs = d.getTarget() and
7474
bbIndex(bb, d, i)
7575
or
7676
exists (PropertyPattern pp |
77-
def = pp.getValuePattern() and
77+
lhs = pp.getValuePattern() and
7878
bbIndex(bb, pp, i)
7979
)
8080
or
8181
exists (ObjectPattern op |
82-
def = op.getRest() and
83-
bbIndex(bb, def, i)
82+
lhs = op.getRest() and
83+
bbIndex(bb, lhs, i)
8484
)
8585
or
8686
exists (ArrayPattern ap |
87-
def = ap.getAnElement() and
88-
bbIndex(bb, def, i)
87+
lhs = ap.getAnElement() and
88+
bbIndex(bb, lhs, i)
8989
)
9090
)
9191
}

0 commit comments

Comments
 (0)