Merge pull request #13459 from github/sashabu/no-path-hash

Swift: Don't use `std::hash<fs::path>`.

Author: sashabu

swift/extractor/infra/SwiftLocationExtractor.h

@@ -104,7 +104,7 @@ class SwiftLocationExtractor {
  private:
   TrapLabel<FileTag> fetchFileLabel(const std::filesystem::path& file);
   TrapDomain& trap;
-  std::unordered_map<std::filesystem::path, TrapLabel<FileTag>> store;
+  std::unordered_map<std::filesystem::path, TrapLabel<FileTag>, codeql::PathHash> store;
 };
 
 template <typename Locatable>

swift/extractor/infra/file/BUILD.bazel

@@ -9,26 +9,7 @@ swift_cc_library(
     hdrs = glob(
         ["*.h"],
         exclude = ["FsLogger.h"],
-    ) + [":path_hash_workaround"],
+    ),
     visibility = ["//swift:__subpackages__"],
     deps = ["//swift/logging"],
 )
-
-genrule(
-    name = "path_hash_workaround",
-    srcs = [
-        "PathHash.h.workaround",
-        "PathHash.h.fixed",
-    ],
-    outs = ["PathHash.h"],
-    # see if https://cplusplus.github.io/LWG/issue3657 is fixed with the current compiler or not
-    # if fixed, PathHash.h.workaround will not compile
-    cmd = "\n".join([
-        "if clang -c -x c++ -std=c++20 -Wno-pragma-once-outside-header \\",
-        "    $(rootpath PathHash.h.workaround) -o /dev/null &> /dev/null; then",
-        "  cp $(rootpath PathHash.h.workaround) $@",
-        "else",
-        "  cp $(rootpath PathHash.h.fixed) $@",
-        "fi",
-    ]),
-)

swift/extractor/infra/file/PathHash.h

@@ -0,0 +1,11 @@
+#pragma once
+
+#include <filesystem>
+
+namespace codeql {
+struct PathHash {
+  auto operator()(const std::filesystem::path& path) const {
+    return std::filesystem::hash_value(path);
+  }
+};
+}  // namespace codeql

swift/extractor/infra/file/PathHash.h.fixed

@@ -114,7 +114,6 @@ class FileInterceptor {
   }
 
   int open(const char* path, int flags, mode_t mode = 0) const {
-    fs::path fsPath{path};
     CODEQL_ASSERT((flags & O_ACCMODE) == O_RDONLY, "We should only be intercepting file reads");
     // try to use the hash map first
     errno = 0;
@@ -162,7 +161,7 @@ class FileInterceptor {
 };
 
 std::optional<std::string> getHashOfRealFile(const fs::path& path) {
-  static std::unordered_map<fs::path, std::string> cache;
+  static std::unordered_map<fs::path, std::string, codeql::PathHash> cache;
   auto resolved = resolvePath(path);
   if (auto found = cache.find(resolved); found != cache.end()) {
     return found->second;