Skip to content

Commit 33fdb0f

Browse files
author
Stephan Brandauer
committed
Java: remove superfluous characteristic
1 parent 2000f22 commit 33fdb0f

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

java/ql/src/Telemetry/AutomodelApplicationModeCharacteristics.qll

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -325,23 +325,6 @@ private class OtherArgumentToModeledMethodCharacteristic extends Characteristics
325325
}
326326
}
327327

328-
/**
329-
* A negative characteristic that indicates that an endpoint is not part of the source code for the project being
330-
* analyzed.
331-
*
332-
* WARNING: These endpoints should not be used as negative samples for training, because they are not necessarily
333-
* non-sinks. They are merely not interesting sinks to run through the ML model.
334-
*
335-
* TODO: Check that this actually does anything.
336-
*/
337-
private class IsExternalCharacteristic extends CharacteristicsImpl::LikelyNotASinkCharacteristic {
338-
IsExternalCharacteristic() { this = "external" }
339-
340-
override predicate appliesToEndpoint(Endpoint e) {
341-
not exists(e.getLocation().getFile().getRelativePath())
342-
}
343-
}
344-
345328
/**
346329
* A negative characteristic that indicates that an endpoint is not a `to` node for any known taint step. Such a node
347330
* cannot be tainted, because taint can't flow into it.

0 commit comments

Comments
 (0)