Skip to content

Commit 31e1706

Browse files
committed
QL style guide: Address some review comments.
1 parent 6feb1d0 commit 31e1706

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/ql-style-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ select c, "This call to '$@' is deprecated because " + reason + ".",
5454
- Immediately after `if`, `then`, or `else` keywords. The `then` and `else` parts *should* be consistent.
5555
1. *Avoid* other line breaks in declarations, other than to break long lines.
5656
1. When operands of *binary operators* span two lines, the operator *should* be placed at the end of the first line.
57-
1. If the parameter list needs to be broken across multiple lines then there must *must* be a line break after the opening `(`, the parameter declarations indented one level, and the `) {` on its own line at the outer indentation.
57+
1. If the parameter list needs to be broken across multiple lines then there *must* be a line break after the opening `(`, the parameter declarations indented one level, and the `) {` *must* be on its own line at the outer indentation.
5858

5959
### Examples
6060

@@ -302,7 +302,7 @@ deprecated Expr getInitializer()
302302
- Spanning multiple lines. The opening parenthesis *should* be placed at the end of the preceding line, the body should be indented one level, and the closing bracket should be placed on a new line at the outer indentation.
303303
1. *Quantifiers/aggregations* *can* be written:
304304
- Within a single line. In this case, there is no space to the inside of the parentheses, or after the quantifier keyword.
305-
- Across multiple lines. In this case, type declarations are on the same line as the quantifier with the `|` at the end of the same line as the quantifier, the second `|` *must* be at the end of the same line as the quantifier or on its own line at the outer indentation, and the body of the quantifier *must* be indented one level. The closing `)` is written on a new line, at the outer indentation. If the type declarations need to be broken across multiple lines then there must *must* be a line break after the opening `(`, the type declarations indented one level, and the first `|` on its own line at the outer indentation.
305+
- Across multiple lines. In this case, type declarations are on the same line as the quantifier with the first `|` at the same line as the quantifier, the second `|` *must* be at the end of the same line as the quantifier or on its own line at the outer indentation, and the body of the quantifier *must* be indented one level. The closing `)` is written on a new line, at the outer indentation. If the type declarations need to be broken across multiple lines then there must *must* be a line break after the opening `(`, the type declarations indented one level, and the first `|` on its own line at the outer indentation.
306306
1. `if`-`then`-`else` *can* be written:
307307
- On a single line
308308
- With the *body* after the `if`/`then`/`else` keyword

0 commit comments

Comments
 (0)