Changing the name (file & tags) to match the JS version.

Author: raulgarciamsft

…ly Bugs/Likely Typos/illDefinedForLoop.c …Likely Typos/inconsistentLoopDirection.ccpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.c renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.c cpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.c renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.c

@@ -14,7 +14,7 @@
 
 <example>
 <p>In the following example, the initialization statement (<code>i = 0</code>) and the condition expression (<code>i < 100</code>) indicate that the intended iteration expression should have been incrementing, but instead a postfix decrement operator is used (<code>i--</code>).</p>
-<sample src="illDefinedForLoop.c" />
+<sample src="inconsistentLoopDirection.c" />
 
 <p>To fix this issue, change the iteration expression to match the direction of the initialization statement and the condition expression: <code>i++</code>.</p>
 </example>

…ugs/Likely Typos/illDefinedForLoop.qhelp …ly Typos/inconsistentLoopDirection.qhelpcpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.qhelp renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.qhelp cpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.qhelp renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.qhelp

@@ -1,11 +1,13 @@
 /**
- * @name Ill-defined for loop
+ * @name Inconsistent direction of for loop
  * @description A for-loop iteration expression goes backward with respect of the initialization statement and condition expression.
- * @id cpp/ill-defined-for-loop
  * @kind problem
- * @problem.severity warning
+ * @problem.severity error
  * @precision high
- * @tags external/microsoft/6293
+ * @id cpp/inconsistent-loop-direction
+ * @tags correctness
+ *       external/cwe/cwe-835 
+ *       external/microsoft/6293
  * @msrc.severity important
  */
 import cpp

…y Bugs/Likely Typos/illDefinedForLoop.ql …ikely Typos/inconsistentLoopDirection.qlcpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.ql renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql cpp/ql/src/Likely Bugs/Likely Typos/illDefinedForLoop.ql renamed to cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql

@@ -144,7 +144,7 @@ void InvalidConditionUnsignedCornerCase()
 
 void NegativeTestCase()
 {
-    for (int i = 0; (200 - i) < 100; i--)
+    for (int i = 0; (100 - i) < 200; i--)
     {
         // code ...
     }

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/illDefinedForLoop/illDefinedForLoop.expected

@@ -0,0 +1,22 @@
+| inconsistentLoopDirection.c:5:5:7:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.c:13:5:15:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.c:27:5:29:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.c:35:5:37:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.c:48:5:50:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.c:58:5:60:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:5:5:7:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.cpp:13:5:15:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:27:5:29:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.cpp:35:5:37:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:46:5:48:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.cpp:54:5:56:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:69:5:71:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (min), but the terminal condition is higher (max). |
+| inconsistentLoopDirection.cpp:77:5:79:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (max), but the terminal condition is lower (min). |
+| inconsistentLoopDirection.cpp:91:5:93:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (100). |
+| inconsistentLoopDirection.cpp:101:5:103:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:118:5:120:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (max), but the terminal condition is always false. |
+| inconsistentLoopDirection.cpp:122:5:124:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (min), but the terminal condition is always false. |
+| inconsistentLoopDirection.cpp:133:5:135:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (100), but the terminal condition is always false. |
+| inconsistentLoopDirection.cpp:140:5:142:5 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (200), but the terminal condition is lower (0). |
+| inconsistentLoopDirection.cpp:175:5:175:36 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts downward from a value (0), but the terminal condition is higher (10). |
+| inconsistentLoopDirection.cpp:179:5:179:38 | for(...;...;...) ... | Ill-defined for-loop: a loop using variable "i" counts upward from a value (100), but the terminal condition is lower (0). |

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/illDefinedForLoop/illDefinedForLoop.qlref

@@ -0,0 +1 @@
+Likely Bugs/Likely Typos/inconsistentLoopDirection.ql