PS: Add matchesName and getAName to make it easier to match case insensitively.

MathiasVP · MathiasVP · commit 2e0560119c8b · 2025-04-23T12:34:08.000+01:00
diff --git a/powershell/ql/lib/semmle/code/powershell/ast/internal/Parameter.qll b/powershell/ql/lib/semmle/code/powershell/ast/internal/Parameter.qll
@@ -3,7 +3,13 @@ private import AstImport
 class Parameter extends Variable instanceof ParameterImpl {
   string getLowerCaseName() { result = super.getLowerCaseNameImpl() }
 
-  final predicate hasName(string name) { name = this.getName() }
+  bindingset[name]
+  pragma[inline_late]
+  final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+  bindingset[result]
+  pragma[inline_late]
+  final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
 
   override Ast getChild(ChildIndex childIndex) {
     result = Variable.super.getChild(childIndex)
diff --git a/powershell/ql/lib/semmle/code/powershell/ast/internal/Raw/Command.qll b/powershell/ql/lib/semmle/code/powershell/ast/internal/Raw/Command.qll
@@ -32,6 +32,14 @@ class Cmd extends @command, CmdBase {
   /** Gets the name of the command without any qualifiers. */
   string getLowerCaseName() { parseCommandName(this, _, result) }
 
+  bindingset[name]
+  pragma[inline_late]
+  final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+  bindingset[result]
+  pragma[inline_late]
+  final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
+
   /** Holds if the command is qualified. */
   predicate isQualified() { parseCommandName(this, any(string s | s != ""), _) }
 
@@ -70,7 +78,7 @@ class Cmd extends @command, CmdBase {
           // sourcing operator) the 0'th element is not the command name, but
           // rather the thing to invoke. These all appear to be commands with
           // an empty string as the command name.
-          this.getCommandName() = ""
+          this.matchesName("")
         ) and
         e = this.getElement(j) and
         (
diff --git a/powershell/ql/lib/semmle/code/powershell/ast/internal/Variable.qll b/powershell/ql/lib/semmle/code/powershell/ast/internal/Variable.qll
@@ -149,6 +149,14 @@ module Public {
 
     final override string toString() { result = this.getLowerCaseName() }
 
+    bindingset[name]
+    pragma[inline_late]
+    final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+    bindingset[result]
+    pragma[inline_late]
+    final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
+
     final override Location getLocation() { result = super.getLocationImpl() }
 
     Scope getDeclaringScope() { getRawAst(result) = super.getDeclaringScopeImpl() }
diff --git a/powershell/ql/lib/semmle/code/powershell/controlflow/CfgNodes.qll b/powershell/ql/lib/semmle/code/powershell/controlflow/CfgNodes.qll
@@ -542,6 +542,14 @@ module ExprNodes {
 
     predicate hasLowerCaseName(string name) { this.getLowerCaseName() = name }
 
+    bindingset[name]
+    pragma[inline_late]
+    final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+    bindingset[result]
+    pragma[inline_late]
+    final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
+
     /** Gets the i'th positional argument to this call. */
     ExprCfgNode getPositionalArgument(int i) {
       e.hasCfgChild(e.getPositionalArgument(i), this, result)
@@ -1043,6 +1051,14 @@ module ExprNodes {
 
     string getLowerCaseName() { result = e.getLowerCaseName() }
 
+    bindingset[name]
+    pragma[inline_late]
+    final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+    bindingset[result]
+    pragma[inline_late]
+    final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
+
     int getPosition() { result = e.getPosition() }
   }
 
diff --git a/powershell/ql/lib/semmle/code/powershell/controlflow/internal/Completion.qll b/powershell/ql/lib/semmle/code/powershell/controlflow/internal/Completion.qll
@@ -24,7 +24,7 @@ private newtype TCompletion =
 
 private predicate commandThrows(CallExpr c, boolean unconditional) {
   c.getNamedArgument("ErrorAction").getValue().asString() = "Stop" and
-  if c.getName() = "Write-Error" then unconditional = true else unconditional = false
+  if c.matchesName("Write-Error") then unconditional = true else unconditional = false
 }
 
 pragma[noinline]
diff --git a/powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll b/powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll
@@ -514,7 +514,7 @@ class NamedSet extends NamedSet0 {
 
   /** Gets a function that has a parameter for each name in this set. */
   Function getAFunction() {
-    forex(string name | name = this.getAName() | result.getAParameter().hasName(name))
+    forex(string name | name = this.getAName() | result.getAParameter().matchesName(name))
     or
     this.isEmpty() and
     exists(result)
diff --git a/powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPublic.qll b/powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPublic.qll
@@ -508,6 +508,14 @@ class CallNode extends ExprNode {
 
   string getLowerCaseName() { result = call.getLowerCaseName() }
 
+  bindingset[name]
+  pragma[inline_late]
+  final predicate matchesName(string name) { this.getLowerCaseName() = name.toLowerCase() }
+
+  bindingset[result]
+  pragma[inline_late]
+  final string getAName() { result.toLowerCase() = this.getLowerCaseName() }
+
   Node getQualifier() { result.asExpr() = call.getQualifier() }
 
   /** Gets the i'th argument to this call. */
diff --git a/powershell/ql/lib/semmle/code/powershell/frameworks/SystemManagementAutomationEngineIntrinsics/EngineIntrinsics.qll b/powershell/ql/lib/semmle/code/powershell/frameworks/SystemManagementAutomationEngineIntrinsics/EngineIntrinsics.qll
@@ -6,7 +6,7 @@ module EngineIntrinsics {
   private class EngineIntrinsicsGlobalEntry extends ModelInput::TypeModel {
     override DataFlow::Node getASource(string type) {
       type = "System.Management.Automation.EngineIntrinsics" and
-      result.asExpr().getExpr().(VarReadAccess).getVariable().getName().toLowerCase() = "executioncontext"
+      result.asExpr().getExpr().(VarReadAccess).getVariable().matchesName("ExecutionContext")
     }
   }
 }
diff --git a/powershell/ql/lib/semmle/code/powershell/frameworks/data/internal/ApiGraphModelsSpecific.qll b/powershell/ql/lib/semmle/code/powershell/frameworks/data/internal/ApiGraphModelsSpecific.qll
@@ -63,7 +63,7 @@ API::Node getExtraNodeFromPath(string type, AccessPath path, int n) {
   n = 1 and
   exists(string methodName, DataFlow::CallNode call |
     methodMatchedByName(path, methodName) and
-    call.getName() = methodName and
+    call.matchesName(methodName) and
     result.(API::MethodAccessNode).asCall() = call
   )
 }
diff --git a/powershell/ql/lib/semmle/code/powershell/security/CommandInjectionCustomizations.qll b/powershell/ql/lib/semmle/code/powershell/security/CommandInjectionCustomizations.qll
@@ -42,7 +42,7 @@ module CommandInjection {
     SystemCommandExecutionSink() {
       // An argument to a call
       exists(DataFlow::CallNode call |
-        call.getName() = ["Invoke-Expression", "iex"] and
+        call.matchesName(["Invoke-Expression", "iex"]) and
         call.getAnArgument() = this
       )
       or
@@ -57,7 +57,7 @@ module CommandInjection {
   class AddTypeSink extends Sink {
     AddTypeSink() {
       exists(DataFlow::CallNode call |
-        call.getName() = "Add-Type" and
+        call.matchesName("Add-Type") and
         call.getAnArgument() = this
       )
     }
@@ -94,8 +94,8 @@ class AddScriptInvokeSink extends Sink {
   AddScriptInvokeSink() { 
       exists(InvokeMemberExpr addscript, InvokeMemberExpr create | 
           this.asExpr().getExpr() = addscript.getAnArgument() and
-          addscript.getName() = "AddScript" and
-          create.getName() = "Create" and
+          addscript.matchesName("AddScript") and
+          create.matchesName("Create") and
 
           addscript.getQualifier().(InvokeMemberExpr) = create and
           create.getQualifier().(TypeNameExpr).getName() = "PowerShell"
@@ -109,7 +109,7 @@ class AddScriptInvokeSink extends Sink {
 class PowershellSink extends Sink {
     PowershellSink() { 
         exists( CmdCall c |        
-            c.getName() = "powershell" | 
+          c.matchesName("powershell") | 
             (
                 this.asExpr().getExpr() = c.getArgument(1) and
                 c.getArgument(0).getValue().asString() = "-command"
@@ -125,28 +125,28 @@ class PowershellSink extends Sink {
 }
 
 class CmdSink extends Sink {
-    CmdSink() { 
-        exists(CmdCall c | 
-            this.asExpr().getExpr() = c.getArgument(1) and
-            c.getName() = "cmd" and
-            c.getArgument(0).getValue().asString() = "/c" 
-        )
-    }   
-    override string getSinkType(){
-        result = "call to Cmd"
-    }
+  CmdSink() { 
+      exists(CmdCall c | 
+          this.asExpr().getExpr() = c.getArgument(1) and
+          c.matchesName("cmd") and
+          c.getArgument(0).getValue().asString() = "/c" 
+      )
+  }   
+  override string getSinkType(){
+      result = "call to Cmd"
+  }
 }
 
 class ForEachObjectSink extends Sink {
-    ForEachObjectSink() { 
-        exists(CmdCall c | 
-            this.asExpr().getExpr() = c.getAnArgument() and
-            c.getName() = "Foreach-Object" 
-        )
-    }   
-    override string getSinkType(){
-        result = "call to ForEach-Object"
-    }
+  ForEachObjectSink() { 
+      exists(CmdCall c | 
+          this.asExpr().getExpr() = c.getAnArgument() and
+          c.matchesName("Foreach-Object")
+      )
+  }   
+  override string getSinkType(){
+      result = "call to ForEach-Object"
+  }
 }
 
 class InvokeSink extends Sink {
@@ -162,17 +162,17 @@ class InvokeSink extends Sink {
 }
 
 class CreateScriptBlockSink extends Sink {
-    CreateScriptBlockSink() { 
-        exists(InvokeMemberExpr ie | 
-            this.asExpr().getExpr() = ie.getAnArgument() and
-            ie.getName() = "Create" and
-            ie.getQualifier().(TypeNameExpr).getName() = "ScriptBlock"
-        )
-    }   
-    override string getSinkType(){
-        result = "call to CreateScriptBlock"
-    }
-}
+  CreateScriptBlockSink() { 
+      exists(InvokeMemberExpr ie | 
+          this.asExpr().getExpr() = ie.getAnArgument() and
+          ie.matchesName("Create") and
+          ie.getQualifier().(TypeNameExpr).getName() = "ScriptBlock"
+      )
+  }   
+  override string getSinkType(){
+      result = "call to CreateScriptBlock"
+  }
+}       
 
 class NewScriptBlockSink extends Sink {
     NewScriptBlockSink() { 
@@ -219,12 +219,12 @@ class ExpandStringSink extends Sink {
   }
   
   class SingleQuoteSanitizer extends Sanitizer {
-    SingleQuoteSanitizer() {
-      exists(ExpandableStringExpr e, VarReadAccess v |
-        v = this.asExpr().getExpr() and
-        e.getUnexpandedValue().toLowerCase().matches("%'$" + v.getVariable().getLowerCaseName() + "'%") and
-        e.getAnExpr() = v
-      )
+    SingleQuoteSanitizer() { 
+        exists(ExpandableStringExpr e, VarReadAccess v | 
+            v = this.asExpr().getExpr()  and
+            e.getUnexpandedValue().toLowerCase().matches("%'$" + v.getVariable().getLowerCaseName() + "'%") and
+            e.getAnExpr() = v
+        )
     }
   }
 }
diff --git a/powershell/ql/src/experimental/CommandInjection.ql b/powershell/ql/src/experimental/CommandInjection.ql
@@ -60,7 +60,7 @@ Expr getAllSubExpressions(Expr expr) {
 Expr dangerousCommandElement(CallExpr command) {
   (
     command instanceof CallOperator or
-    command.getName() = "Invoke-Expression"
+    command.matchesName("Invoke-Expression")
   ) and
   result = getAllSubExpressions(command.getAnArgument())
 }
diff --git a/powershell/ql/src/experimental/ConvertToSecureStringAsPlainText.ql b/powershell/ql/src/experimental/ConvertToSecureStringAsPlainText.ql
@@ -14,6 +14,6 @@
 
  from CmdCall c 
  where 
- c.getName() = "ConvertTo-SecureString" and
+ c.matchesName("ConvertTo-SecureString") and
  c.hasNamedArgument("asplaintext")
  select c, "Use of AsPlainText parameter in ConvertTo-SecureString call"
diff --git a/powershell/ql/src/experimental/HardcodedComputerName.ql b/powershell/ql/src/experimental/HardcodedComputerName.ql
@@ -13,5 +13,5 @@
 import powershell
 
 from Argument a 
-where a.getName() = "computername" and exists(a.getValue())
+where a.matchesName("computername") and exists(a.getValue())
 select a, "ComputerName argument is hardcoded to" + a.getValue()
diff --git a/powershell/ql/src/experimental/UsernameOrPasswordParameter.ql b/powershell/ql/src/experimental/UsernameOrPasswordParameter.ql
@@ -13,5 +13,5 @@
  import powershell
 
 from Parameter p
-where p.getName().toLowerCase() = ["username", "password"]
+where p.matchesName(["username", "password"])
 select p, "Do not use username or password parameters."
diff --git a/powershell/ql/src/queries/security/cwe-078/DoNotUseInvokeExpression.ql b/powershell/ql/src/queries/security/cwe-078/DoNotUseInvokeExpression.ql
@@ -12,5 +12,5 @@ import powershell
 import semmle.code.powershell.dataflow.DataFlow
 
 from CmdCall call 
-where call.getName() = "Invoke-Expression"
+where call.matchesName("Invoke-Expression")
 select call, "Do not use Invoke-Expression. It is a command injection risk."

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ private newtype TCompletion =`
`24`	`24`
`25`	`25`	`private predicate commandThrows(CallExpr c, boolean unconditional) {`
`26`	`26`	`c.getNamedArgument("ErrorAction").getValue().asString() = "Stop" and`
`27`		`- if c.getName() = "Write-Error" then unconditional = true else unconditional = false`
	`27`	`+ if c.matchesName("Write-Error") then unconditional = true else unconditional = false`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`pragma[noinline]`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ module EngineIntrinsics {`
`6`	`6`	`private class EngineIntrinsicsGlobalEntry extends ModelInput::TypeModel {`
`7`	`7`	`override DataFlow::Node getASource(string type) {`
`8`	`8`	`type = "System.Management.Automation.EngineIntrinsics" and`
`9`		`- result.asExpr().getExpr().(VarReadAccess).getVariable().getName().toLowerCase() = "executioncontext"`
	`9`	`+ result.asExpr().getExpr().(VarReadAccess).getVariable().matchesName("ExecutionContext")`
`10`	`10`	`}`
`11`	`11`	`}`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ API::Node getExtraNodeFromPath(string type, AccessPath path, int n) {`
`63`	`63`	`n = 1 and`
`64`	`64`	`exists(string methodName, DataFlow::CallNode call \|`
`65`	`65`	`methodMatchedByName(path, methodName) and`
`66`		`- call.getName() = methodName and`
	`66`	`+ call.matchesName(methodName) and`
`67`	`67`	`result.(API::MethodAccessNode).asCall() = call`
`68`	`68`	`)`
`69`	`69`	`}`