1. Rename AgentSDK -> AgentSdk

2. Remove redundant constant comparison barriers. This is already happening by default by the taint tracking library.

Author: BazookaMusic

javascript/ql/lib/semmle/javascript/frameworks/OpenAI.qll

@@ -207,7 +207,7 @@ module OpenAI {
  * This module retains only role-filtered sinks, callback-based sinks, and
  * unsafe agent detection that MaD cannot express.
  */
-module AgentSDK {
+module AgentSdk {
   /** Gets a reference to the OpenAI Agents SDK module. */
   API::Node moduleRef() {
     result = API::moduleImport("@openai/agents")

javascript/ql/lib/semmle/javascript/security/dataflow/SystemPromptInjectionCustomizations.qll

@@ -56,7 +56,7 @@ module SystemPromptInjection {
     PromptContentSink() {
       this = OpenAI::getSystemOrAssistantPromptNode().asSink()
       or
-      this = AgentSDK::getSystemOrAssistantPromptNode().asSink()
+      this = AgentSdk::getSystemOrAssistantPromptNode().asSink()
       or
       this = Anthropic::getSystemOrAssistantPromptNode().asSink()
       or
@@ -68,12 +68,6 @@ module SystemPromptInjection {
     }
   }
 
-  private class ConstCompareAsSanitizerGuard extends Sanitizer {
-    ConstCompareAsSanitizerGuard() {
-      this = DataFlow::MakeBarrierGuard<ConstCompareBarrierGuard>::getABarrierNode()
-    }
-  }
-
   /**
    * Content placed in a message with `role: "user"` is not a system prompt
    * injection vector; it is intended user-role content.
@@ -91,20 +85,4 @@ module SystemPromptInjection {
       )
     }
   }
-
-  /**
-   * A comparison with a constant, considered as a sanitizer-guard.
-   */
-  private class ConstCompareBarrierGuard extends DataFlow::ValueNode {
-    override EqualityTest astNode;
-
-    ConstCompareBarrierGuard() { astNode.hasOperands(_, any(ConstantString cs)) }
-
-    predicate blocksExpr(boolean outcome, Expr e) {
-      outcome = astNode.getPolarity() and
-      e = astNode.getLeftOperand() and
-      e = astNode.getAnOperand() and
-      not e instanceof ConstantString
-    }
-  }
 }