C++: Test for IntMultToLong on char-typed numbers

jbj · jbj · commit 2b5d15082965 · 2018-09-24T14:36:36.000+02:00
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/IntMultToLong/IntMultToLong.c b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/IntMultToLong/IntMultToLong.c
@@ -88,3 +88,7 @@ void use_printf(float f, double d)
 		// ^ there's a float -> double varargs promotion here, but it's unlikely that the author anticipates requiring a double
 	printf("%f", d * d); // safe
 }
+
+size_t three_chars(unsigned char a, unsigned char b, unsigned char c) {
+    return a * b * c; // at most 16581375 [FALSE POSITIVE]
+}
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/IntMultToLong/IntMultToLong.expected b/cpp/ql/test/query-tests/Likely Bugs/Arithmetic/IntMultToLong/IntMultToLong.expected
@@ -7,3 +7,4 @@
 | IntMultToLong.c:61:23:61:33 | ... * ... | Multiplication result may overflow 'int' before it is converted to 'long long'. |
 | IntMultToLong.c:63:23:63:40 | ... * ... | Multiplication result may overflow 'int' before it is converted to 'long long'. |
 | IntMultToLong.c:75:9:75:13 | ... * ... | Multiplication result may overflow 'int' before it is converted to 'size_t'. |
+| IntMultToLong.c:93:12:93:20 | ... * ... | Multiplication result may overflow 'int' before it is converted to 'size_t'. |

Original file line number	Diff line number	Diff line change
`@@ -88,3 +88,7 @@ void use_printf(float f, double d)`
`88`	`88`	`// ^ there's a float -> double varargs promotion here, but it's unlikely that the author anticipates requiring a double`
`89`	`89`	`printf("%f", d * d); // safe`
`90`	`90`	`}`
	`91`	`+`
	`92`	`+size_t three_chars(unsigned char a, unsigned char b, unsigned char c) {`
	`93`	`+ return a * b * c; // at most 16581375 [FALSE POSITIVE]`
	`94`	`+}`