Skip to content

Commit 2b1d9c8

Browse files
committed
Updates last library difference
I'm not entirely sure if `getLiteralObject` and `getLiteralValue` are equivalent, and there don't see to be library tests for this
1 parent 210387a commit 2b1d9c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

python/ql/src/Expressions/IsComparisons.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ predicate invalid_portable_is_comparison(Compare comp, Cmpop op, ClassValue cls)
110110
/* OK to use 'is' when comparing items from a known set of objects */
111111
not exists(Expr left, Expr right, Value val |
112112
comp.compares(left, op, right) and
113-
exists(ImmutableLiteral il | il.getLiteralObject() = val) |
113+
exists(ImmutableLiteral il | il.getLiteralValue() = val) |
114114
left.pointsTo(val) and right.pointsTo(val)
115115
or
116116
/* Simple constant in module, probably some sort of sentinel */

0 commit comments

Comments
 (0)