python: No fieldFlowBranchLimit for SummarizedCallables

yoff · yoff · commit 2a0c451d2d3c · 2024-03-18T10:29:36.000+01:00
Like #15689 for Ruby.
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplSpecific.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplSpecific.qll
@@ -22,4 +22,6 @@ module PythonDataFlow implements InputSig {
   predicate neverSkipInPathGraph = Private::neverSkipInPathGraph/1;
 
   Node exprNode(DataFlowExpr e) { result = Public::exprNode(e) }
+
+  predicate ignoreFieldFlowBranchLimit(DataFlowCallable c) { exists(c.asLibraryCallable()) }
 }
diff --git a/python/ql/test/experimental/dataflow/summaries/conflicting_summaries.py b/python/ql/test/experimental/dataflow/summaries/conflicting_summaries.py
@@ -7,7 +7,7 @@
 # can be concluded from its definition. This seems to discard all summaries, including
 # the one with flow to `ReturnValue.Attribute[pattern]`.
 ensure_tainted(
-    with_subpath(ts).pattern,  # $ MISSING: tainted
+    with_subpath(ts).pattern,  # $ tainted
     with_subpath(ts),  # $ tainted
     with_subpath(ts),  # $ tainted
 )

Original file line number	Diff line number	Diff line change
`@@ -22,4 +22,6 @@ module PythonDataFlow implements InputSig {`
`22`	`22`	`predicate neverSkipInPathGraph = Private::neverSkipInPathGraph/1;`
`23`	`23`
`24`	`24`	`Node exprNode(DataFlowExpr e) { result = Public::exprNode(e) }`
	`25`	`+`
	`26`	`+ predicate ignoreFieldFlowBranchLimit(DataFlowCallable c) { exists(c.asLibraryCallable()) }`
`25`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`# can be concluded from its definition. This seems to discard all summaries, including`
`8`	`8`	# the one with flow to `ReturnValue.Attribute[pattern]`.
`9`	`9`	`ensure_tainted(`
`10`		`- with_subpath(ts).pattern, # $ MISSING: tainted`
	`10`	`+ with_subpath(ts).pattern, # $ tainted`
`11`	`11`	`with_subpath(ts), # $ tainted`
`12`	`12`	`with_subpath(ts), # $ tainted`
`13`	`13`	`)`