JS: Add underlyingType test

Author: asgerf

javascript/ql/test/library-tests/UnderlyingTypes/expressBulkExport.ts

@@ -0,0 +1 @@
+export * from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressBulkExport.use.ts

@@ -0,0 +1,7 @@
+import { Request, Response } from './expressBuilkExport';
+
+function t1(req: Request) { // $ MISSING: hasUnderlyingType='express'.Request
+}
+
+function t2(res: Response) { // $ MISSING: hasUnderlyingType='express'.Response
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressSelectiveExport.ts

@@ -0,0 +1 @@
+export { Request } from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressSelectiveExport.use.ts

@@ -0,0 +1,7 @@
+import { Request, Response } from './expressSelectiveExport';
+
+function t1(req: Request) { // $ MISSING: hasUnderlyingType='express'.Request
+}
+
+function t2(res: Response) { // none, not exported
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressWrapperExport.ts

@@ -0,0 +1 @@
+export * as wrapper from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressWrapperExport.use.ts

@@ -0,0 +1,26 @@
+import { Request, Response, wrapper } from './expressWrapperExport';
+import * as w from './expressWrapperExport';
+
+function t1(req: Request) { // none
+}
+
+function t2(res: Response) { // none
+}
+
+function t3(req: wrapper.Request) { // $ MISSING: hasUnderlyingType='express'.Request
+}
+
+function t4(res: wrapper.Response) { // $ MISSING: hasUnderlyingType='express'.Response
+}
+
+function t5(req: w.wrapper.Request) { // $ MISSING: hasUnderlyingType='express'.Request
+}
+
+function t6(res: w.wrapper.Response) { // $ MISSING: hasUnderlyingType='express'.Response
+}
+
+function t7(req: w.Request) { // none
+}
+
+function t8(res: w.Response) { // none
+}

javascript/ql/test/library-tests/UnderlyingTypes/namedImport.ts

@@ -0,0 +1,4 @@
+import { Request } from 'express';
+
+function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+}

javascript/ql/test/library-tests/UnderlyingTypes/namespaceImport.ts

@@ -0,0 +1,10 @@
+import * as express from 'express';
+
+function t1(e: typeof express) { // $ MISSING: hasUnderlyingType='express'
+}
+
+function t2(req: express.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t3(req: Request) { // none, not in scope
+}

javascript/ql/test/library-tests/UnderlyingTypes/test.expected

@@ -0,0 +1,26 @@
+import javascript
+private import utils.test.InlineExpectationsTest
+
+bindingset[x, y]
+private string join(string x, string y) {
+  if x = "" or y = "" then result = x + y else result = x + "." + y
+}
+
+module TestConfig implements TestSig {
+  string getARelevantTag() { result = "hasUnderlyingType" }
+
+  predicate hasActualResult(Location location, string element, string tag, string value) {
+    element = "" and
+    tag = "hasUnderlyingType" and
+    exists(DataFlow::SourceNode sn | location = sn.getLocation() |
+      sn.hasUnderlyingType(value)
+      or
+      exists(string mod, string name |
+        sn.hasUnderlyingType(mod, name) and
+        value = join("'" + mod + "'", name)
+      )
+    )
+  }
+}
+
+import MakeTest<TestConfig>