Shared: Clippy fixes

Use clearer methods where appropriate.

Author: hmac

shared/tree-sitter-extractor/src/diagnostics.rs

@@ -255,27 +255,27 @@ impl DiagnosticMessage {
             match args.get(i) {
                 Some(MessageArg::Code(t)) => {
                     plain.push_str(t);
-                    if t.len() > 0 {
+                    if !t.is_empty() {
                         let count = longest_backtick_sequence_length(t) + 1;
                         markdown.push_str(&"`".repeat(count));
                         if count > 1 {
-                            markdown.push_str(" ");
+                            markdown.push(' ');
                         }
                         markdown.push_str(t);
                         if count > 1 {
-                            markdown.push_str(" ");
+                            markdown.push(' ');
                         }
                         markdown.push_str(&"`".repeat(count));
                     }
                 }
                 Some(MessageArg::Link(text, url)) => {
                     plain.push_str(text);
                     self.help_link(url);
-                    markdown.push_str("[");
+                    markdown.push('[');
                     markdown.push_str(text);
                     markdown.push_str("](");
                     markdown.push_str(url);
-                    markdown.push_str(")");
+                    markdown.push(')');
                 }
                 None => {}
             }

shared/tree-sitter-extractor/src/trap.rs

@@ -97,7 +97,7 @@ impl fmt::Display for Entry {
         match self {
             Entry::FreshId(label) => write!(f, "{}=*", label),
             Entry::MapLabelToKey(label, key) => {
-                write!(f, "{}=@\"{}\"", label, key.replace("\"", "\"\""))
+                write!(f, "{}=@\"{}\"", label, key.replace('"', "\"\""))
             }
             Entry::GenericTuple(name, args) => {
                 write!(f, "{}(", name)?;
@@ -142,7 +142,7 @@ impl fmt::Display for Arg {
             Arg::String(x) => write!(
                 f,
                 "\"{}\"",
-                limit_string(x, MAX_STRLEN).replace("\"", "\"\"")
+                limit_string(x, MAX_STRLEN).replace('"', "\"\"")
             ),
         }
     }