Skip to content

Commit 1de1c15

Browse files
committed
JS: minor fixups
1 parent 2ad9b84 commit 1de1c15

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

javascript/ql/src/semmle/javascript/security/dataflow/UnsafeJQueryPluginCustomizations.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ module UnsafeJQueryPlugin {
115115
}
116116

117117
/**
118-
* Holds if `plugin` has a default option defined a `def`.
118+
* Holds if `plugin` has a default option defined at `def`.
119119
*/
120120
private predicate hasDefaultOption(JQueryPluginMethod plugin, DataFlow::PropWrite def) {
121121
exists(ExtendCall extend, JQueryPluginOptions options, DataFlow::SourceNode default |
@@ -161,7 +161,7 @@ module UnsafeJQueryPlugin {
161161
IsElementSanitizer() {
162162
// common ad hoc sanitizing calls
163163
exists(string name | getCalleeName() = name |
164-
name = "isElement" or name = "isWindow" or name = "isWindow"
164+
name = "isElement" or name = "isDocument" or name = "isWindow"
165165
)
166166
}
167167

@@ -171,7 +171,7 @@ module UnsafeJQueryPlugin {
171171
}
172172

173173
/**
174-
* Expression of like `typeof x.<?> !== "undefined"` or `x.<?>`, which sanitizes `x`, as it is unlikely to be a string afterwards.
174+
* Expression like `typeof x.<?> !== "undefined"` or `x.<?>`, which sanitizes `x`, as it is unlikely to be a string afterwards.
175175
*/
176176
class PropertyPrecenseSanitizer extends TaintTracking::SanitizerGuardNode, DataFlow::ValueNode {
177177
DataFlow::Node input;

0 commit comments

Comments
 (0)