C++/C#: Autoformat all the things

Author: dave-bartolomeo

cpp/ql/src/semmle/code/cpp/ir/implementation/IRType.qll

@@ -7,27 +7,13 @@ private import internal.IRTypeInternal
 private newtype TIRType =
   TIRVoidType() or
   TIRUnknownType() or
-  TIRErrorType() {
-    Language::hasErrorType()
-  } or
-  TIRBooleanType(int byteSize) {
-    Language::hasBooleanType(byteSize)
-  } or
-  TIRSignedIntegerType(int byteSize) {
-    Language::hasSignedIntegerType(byteSize)
-  } or
-  TIRUnsignedIntegerType(int byteSize) {
-    Language::hasUnsignedIntegerType(byteSize)
-  } or
-  TIRFloatingPointType(int byteSize) {
-    Language::hasFloatingPointType(byteSize)
-  } or
-  TIRAddressType(int byteSize) {
-    Language::hasAddressType(byteSize)
-  } or
-  TIRFunctionAddressType(int byteSize) {
-    Language::hasFunctionAddressType(byteSize)
-  } or
+  TIRErrorType() { Language::hasErrorType() } or
+  TIRBooleanType(int byteSize) { Language::hasBooleanType(byteSize) } or
+  TIRSignedIntegerType(int byteSize) { Language::hasSignedIntegerType(byteSize) } or
+  TIRUnsignedIntegerType(int byteSize) { Language::hasUnsignedIntegerType(byteSize) } or
+  TIRFloatingPointType(int byteSize) { Language::hasFloatingPointType(byteSize) } or
+  TIRAddressType(int byteSize) { Language::hasAddressType(byteSize) } or
+  TIRFunctionAddressType(int byteSize) { Language::hasFunctionAddressType(byteSize) } or
   TIROpaqueType(Language::OpaqueTypeTag tag, int byteSize) {
     Language::hasOpaqueType(tag, byteSize)
   }
@@ -49,9 +35,7 @@ class IRType extends TIRType {
    * Gets a string that uniquely identifies this `IRType`. This string is often the same as the
    * result of `IRType.toString()`, but for some types it may be more verbose to ensure uniqueness.
    */
-  string getIdentityString() {
-    result = toString()
-  }
+  string getIdentityString() { result = toString() }
 
   /**
    * Gets the size of the type, in bytes, if known.
@@ -215,9 +199,7 @@ class IRFunctionAddressType extends IRSizedType, TIRFunctionAddressType {
 class IROpaqueType extends IRSizedType, TIROpaqueType {
   Language::OpaqueTypeTag tag;
 
-  IROpaqueType() {
-    this = TIROpaqueType(tag, byteSize)
-  }
+  IROpaqueType() { this = TIROpaqueType(tag, byteSize) }
 
   final override string toString() {
     result = "opaque" + byteSize.toString() + "{" + tag.toString() + "}"
@@ -246,7 +228,8 @@ module IRTypeSanity {
 
   query predicate multipleCanonicalLanguageTypes(IRType type, string message) {
     strictcount(type.getCanonicalLanguageType()) > 1 and
-    message = "Type has multiple canonical `LanguageType`s: " + concat(type.getCanonicalLanguageType().toString(), ", ")
+    message = "Type has multiple canonical `LanguageType`s: " +
+        concat(type.getCanonicalLanguageType().toString(), ", ")
   }
 
   query predicate missingIRType(Language::LanguageType type, string message) {
@@ -256,7 +239,8 @@ module IRTypeSanity {
 
   query predicate multipleIRTypes(Language::LanguageType type, string message) {
     strictcount(type.getIRType()) > 1 and
-    message = "`LanguageType` " + type.getAQlClass() + " has multiple `IRType`s: " + concat(type.getIRType().toString(), ", ")
+    message = "`LanguageType` " + type.getAQlClass() + " has multiple `IRType`s: " +
+        concat(type.getIRType().toString(), ", ")
   }
 
   import Language::LanguageTypeSanity

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasedSSA.qll

@@ -354,4 +354,3 @@ MemoryLocation getOperandMemoryLocation(MemoryOperand operand) {
     )
   )
 }
-

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/IRConstruction.qll

@@ -305,9 +305,7 @@ private module Cached {
 
   cached
   predicate needsUnknownOpaqueType(int byteSize) {
-    exists(TranslatedElement element |
-      element.needsUnknownOpaqueType(byteSize)
-    )
+    exists(TranslatedElement element | element.needsUnknownOpaqueType(byteSize))
   }
 
   cached

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll

@@ -455,7 +455,8 @@ class TranslatedSideEffect extends TranslatedElement, TTranslatedArgumentSideEff
       tag instanceof OnlyInstructionTag and
       operandType = arg.getType().getUnspecifiedType() and
       not operandType instanceof DerivedType and
-      operandTag instanceof SideEffectOperandTag |
+      operandTag instanceof SideEffectOperandTag
+    |
       // If the type we select is an incomplete type (e.g. a forward-declared `struct`), there will
       // not be a `CppType` that represents that type. In that case, fall back to `UnknownCppType`.
       result = getTypeForPRValueOrUnknown(operandType)

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll

@@ -65,8 +65,8 @@ private predicate ignoreExprAndDescendants(Expr expr) {
   )
   or
   // Do not translate input/output variables in GNU asm statements
-//  getRealParent(expr) instanceof AsmStmt
-//  or
+  //  getRealParent(expr) instanceof AsmStmt
+  //  or
   ignoreExprAndDescendants(getRealParent(expr)) // recursive case
   or
   // We do not yet translate destructors properly, so for now we ignore any
@@ -617,7 +617,7 @@ abstract class TranslatedElement extends TTranslatedElement {
   int getInstructionResultSize(InstructionTag tag) { none() }
 
   predicate needsUnknownOpaqueType(int byteSize) { none() }
-  
+
   /**
    * If the instruction specified by `tag` is a `StringConstantInstruction`,
    * gets the `StringLiteral` for that instruction.

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll

@@ -54,10 +54,9 @@ abstract class TranslatedExpr extends TranslatedElement {
   abstract predicate producesExprResult();
 
   final CppType getResultType() {
-    if isResultGLValue() then
-      result = getTypeForGLValue(expr.getType())
-    else
-      result = getTypeForPRValue(expr.getType())
+    if isResultGLValue()
+    then result = getTypeForGLValue(expr.getType())
+    else result = getTypeForPRValue(expr.getType())
   }
 
   /**
@@ -338,7 +337,7 @@ abstract class TranslatedCrementOperation extends TranslatedNonConstantExpr {
   final override string getInstructionConstantValue(InstructionTag tag) {
     tag = CrementConstantTag() and
     exists(Type resultType |
-      resultType =  expr.getUnspecifiedType() and
+      resultType = expr.getUnspecifiedType() and
       (
         resultType instanceof IntegralOrEnumType and result = "1"
         or
@@ -353,18 +352,15 @@ abstract class TranslatedCrementOperation extends TranslatedNonConstantExpr {
     exists(Type resultType |
       resultType = expr.getUnspecifiedType() and
       (
-        (
         resultType instanceof ArithmeticType and
         result = getTypeForPRValue(expr.getType())
-        ) or
+        or
         resultType instanceof PointerType and result = getIntType()
       )
     )
   }
 
-  final override predicate hasInstruction(
-    Opcode opcode, InstructionTag tag, CppType resultType
-  ) {
+  final override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
     tag = CrementLoadTag() and
     opcode instanceof Opcode::Load and
     resultType = getTypeForPRValue(expr.getType())
@@ -615,9 +611,7 @@ class TranslatedTransparentConversion extends TranslatedTransparentExpr {
     )
   }
 
-  override TranslatedExpr getOperand() {
-    result = getTranslatedExpr(expr.getExpr())
-  }
+  override TranslatedExpr getOperand() { result = getTranslatedExpr(expr.getExpr()) }
 }
 
 class TranslatedThisExpr extends TranslatedNonConstantExpr {
@@ -1242,7 +1236,7 @@ class TranslatedAssignExpr extends TranslatedAssignment {
   override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
     tag = AssignmentStoreTag() and
     opcode instanceof Opcode::Store and
-    resultType = getTypeForPRValue(expr.getType())  // Always a prvalue
+    resultType = getTypeForPRValue(expr.getType()) // Always a prvalue
   }
 
   override Instruction getInstructionOperand(InstructionTag tag, OperandTag operandTag) {
@@ -1326,8 +1320,9 @@ class TranslatedAssignOperation extends TranslatedAssignment {
   }
 
   private predicate leftOperandNeedsConversion() {
-    getConvertedLeftOperandType().getUnspecifiedType() !=
-      getLeftOperand().getExpr().getUnspecifiedType()
+    getConvertedLeftOperandType().getUnspecifiedType() != getLeftOperand()
+          .getExpr()
+          .getUnspecifiedType()
   }
 
   private Opcode getOpcode() {
@@ -1367,7 +1362,7 @@ class TranslatedAssignOperation extends TranslatedAssignment {
     or
     tag = AssignmentStoreTag() and
     opcode instanceof Opcode::Store and
-    resultType = getTypeForPRValue(expr.getType())  // Always a prvalue
+    resultType = getTypeForPRValue(expr.getType()) // Always a prvalue
     or
     leftOperandNeedsConversion() and
     opcode instanceof Opcode::Convert and
@@ -1577,9 +1572,7 @@ class TranslatedAllocatorCall extends TTranslatedAllocatorCall, TranslatedDirect
     tag = CallTargetTag() and result = expr.getAllocator()
   }
 
-  final override Type getCallResultType() {
-    result = expr.getAllocator().getType()
-  }
+  final override Type getCallResultType() { result = expr.getAllocator().getType() }
 
   final override TranslatedExpr getQualifier() { none() }
 

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedFunction.qll

@@ -234,9 +234,7 @@ class TranslatedFunction extends TranslatedElement, TTranslatedFunction {
   /**
    * Holds if the function has a non-`void` return type.
    */
-  final predicate hasReturnValue() {
-    not func.getUnspecifiedType() instanceof VoidType
-  }
+  final predicate hasReturnValue() { not func.getUnspecifiedType() instanceof VoidType }
 
   /**
    * Gets the single `UnmodeledDefinition` instruction for this function.

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedInitialization.qll

@@ -717,10 +717,9 @@ class TranslatedElementValueInitialization extends TranslatedElementInitializati
   }
 
   private CppType getDefaultValueType() {
-    if elementCount = 1 then
-      result = getTypeForPRValue(getElementType())
-    else
-      result = getUnknownOpaqueType(elementCount * getElementType().getSize())
+    if elementCount = 1
+    then result = getTypeForPRValue(getElementType())
+    else result = getUnknownOpaqueType(elementCount * getElementType().getSize())
   }
 }
 

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedStmt.qll

@@ -165,9 +165,7 @@ class TranslatedReturnValueStmt extends TranslatedReturnStmt, InitializationCont
     result = getInstruction(InitializerVariableAddressTag())
   }
 
-  override Type getTargetType() {
-    result = getEnclosingFunction().getReturnType()
-  }
+  override Type getTargetType() { result = getEnclosingFunction().getReturnType() }
 
   TranslatedInitialization getInitialization() {
     result = getTranslatedInitialization(stmt.getExpr().getFullyConverted())