Merge pull request #577 from markshannon/python-fix-performance-regression-dependencies

taus-semmle · web-flow · commit 1956cd802fc2 · 2018-11-29T16:41:58.000+01:00
Python: Fix performance regression in dependency analysis
diff --git a/python/ql/src/semmle/python/dependencies/Dependencies.qll b/python/ql/src/semmle/python/dependencies/Dependencies.qll
@@ -193,6 +193,7 @@ private predicate defn_of_class_attribute(Assign asgn, Class c, string name) {
 /* Holds if `value` is a value assigned to the `name`d attribute of module `m`. */
 private predicate defn_of_module_attribute(ControlFlowNode value, Module m, string name) {
     exists(DefinitionNode def |
+        def.getScope() = m and
         def.getValue() = value and
         def.(NameNode).getId() = name
     )

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,7 @@ private predicate defn_of_class_attribute(Assign asgn, Class c, string name) {`
`193`	`193`	/* Holds if `value` is a value assigned to the `name`d attribute of module `m`. */
`194`	`194`	`private predicate defn_of_module_attribute(ControlFlowNode value, Module m, string name) {`
`195`	`195`	`exists(DefinitionNode def \|`
	`196`	`+ def.getScope() = m and`
`196`	`197`	`def.getValue() = value and`
`197`	`198`	`def.(NameNode).getId() = name`
`198`	`199`	`)`