Skip to content

Commit 17f1bb4

Browse files
committed
JS: Make API::Node overlay[local?]
We want the type itself to be local but nearly all its member predicates are global.
1 parent f9c7d1d commit 17f1bb4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

javascript/ql/lib/semmle/javascript/ApiGraphs.qll

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ module API {
122122
* Although one may think of API graphs as a tool to find certain program elements in the codebase,
123123
* it can lead to some situations where intuition does not match what works best in practice.
124124
*/
125+
overlay[local?]
125126
class Node extends Impl::TApiNode {
126127
/**
127128
* Get a data-flow node where this value may flow after entering the current codebase.
@@ -1571,9 +1572,11 @@ module API {
15711572
}
15721573

15731574
private module Stage1Input implements StageInputSig {
1575+
overlay[caller]
15741576
pragma[inline]
15751577
predicate isAdditionalUseRoot(Node node) { none() }
15761578

1579+
overlay[caller]
15771580
pragma[inline]
15781581
predicate isAdditionalDefRoot(Node node) { none() }
15791582

0 commit comments

Comments
 (0)