Apply suggestions from code review

Co-Authored-By: mc <42146119+mchammer01@users.noreply.github.com>

Author: erik-krogh

change-notes/1.24/analysis-javascript.md

@@ -39,7 +39,7 @@
 | Missing await (`js/missing-await`) | correctness | Highlights expressions that operate directly on a promise object in a nonsensical way, instead of awaiting its result. Results are shown on LGTM by default. |
 | Prototype pollution in utility function (`js/prototype-pollution-utility`) | security, external/cwe/cwe-400, external/cwe/cwe-471 | Highlights recursive copying operations that are susceptible to prototype pollution. Results are shown on LGTM by default. |
 | Unsafe jQuery plugin (`js/unsafe-jquery-plugin`) | Highlights potential XSS vulnerabilities in unsafely designed jQuery plugins. Results are shown on LGTM by default. |
-| Useless use of cat (`js/useless-use-of-cat`) | correctness, security, maintainability | Highlights command executions of cat where the fs API should be used instead. Results are shown on LGTM by default. |
+| Useless use of cat (`js/useless-use-of-cat`) | correctness, security, maintainability | Highlights command executions of `cat` where the fs API should be used instead. Results are shown on LGTM by default. |
 
 
 ## Changes to existing queries

javascript/ql/src/Security/CWE-078/UselessUseOfCat.qhelp

@@ -3,9 +3,9 @@
 "qhelp.dtd">
 <qhelp>
 <overview>
-<p>Using the unix command <code>cat</code> to simply read a file is a 
-unnecessarily complex way to achieve something that can be done simpler and 
-safer using the Node.js <code>fs.readFile</code> API.
+<p>Using the unix command <code>cat</code> only to read a file is a 
+an unnecessarily complex way to achieve something that can be done in a simpler and 
+safer manner using the Node.js <code>fs.readFile</code> API.
 </p>
 <p>
 The use of <code>cat</code> for simple file reads leads to code that is 
@@ -25,12 +25,11 @@ from the file system.
 
 <sample src="examples/useless-cat.js"/>
 
-<p>The code in the example will break if the input <code>name</code> contain 
-special characters (including space), the code does not work on windows,  
-and if the input is user controlled a command injection attack can happen.</p>
+<p>The code in the example will break if the input <code>name</code> contains 
+special characters (including space). Additionally, it does not work on Windows 
+and if the input is user-controlled, a command injection attack can happen.</p>
 
-<p>To avoid these potential issues the <code>fs.readFile</code> API can be 
-used instead: </p>
+<p>The <code>fs.readFile</code> API should be used to avoid these potential issues:
 
 <sample src="examples/useless-cat-fixed.js"/>
 

javascript/ql/src/Security/CWE-078/UselessUseOfCat.ql

@@ -1,6 +1,6 @@
 /**
  * @name Useless use of cat
- * @description Using `cat`-process to simply read a file is unnecessarily complex, inefficient, unportable, can lead to subtle bugs, or even security vulnerabilities.
+ * @description Using the  `cat` process to read a file is unnecessarily complex, inefficient, unportable, and can lead to subtle bugs, or even security vulnerabilities.
  * @kind problem
  * @problem.severity error
  * @precision high
@@ -22,4 +22,4 @@ where
   if cat.isSync()
   then message = " Can be replaced with a call to fs.readFileSync(..)."
   else message = " Can be replaced with a call to fs.readFile(..)."
-select cat.asExpr().(FirstLineOf), "Useless use of `cat`." + message
+select cat.asExpr().(FirstLineOf), "Useless use of `cat`." + message