CPP: Tag the JPL_C LOC-3 queries.

Author: geoffw0

cpp/ql/src/JPL_C/LOC-3/Rule 13/ExternDeclsInHeader.ql

@@ -4,6 +4,7 @@
  * @kind problem
  * @id cpp/jpl-c/extern-decls-in-header
  * @problem.severity warning
+ * @tags maintainability
  */
 
 import cpp

cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFile.ql

@@ -3,7 +3,10 @@
  * @description Global variables that are not accessed outside their own file should be made static to promote information hiding.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-file
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags maintainability
+ *       modularity
  */
 
 import cpp

cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFunction.ql

@@ -3,7 +3,9 @@
  * @description Global and file-scope variables that are accessed by only one function should be scoped within that function.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-function
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags maintainability
  */
 
 import cpp

cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeLocalHidesGlobal.ql

@@ -3,7 +3,9 @@
  * @description A local variable or parameter that hides a global variable of the same name.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-local-hides-global
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 import cpp
 

cpp/ql/src/JPL_C/LOC-3/Rule 14/CheckingReturnValues.ql

@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/checking-return-values
  * @problem.severity warning
+ * @tags correctness
+ *       reliability
  */
 
 import cpp

cpp/ql/src/JPL_C/LOC-3/Rule 15/CheckingParameterValues.ql

@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/checking-parameter-values
  * @problem.severity warning
+ * @tags correctness
+ *       reliability
  */
 
 import JPL_C.Tasks

cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsConstant.ql

@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-constant
  * @problem.severity warning
+ * @tags maintainability
+ *       reliability
  */
 
 import semmle.code.cpp.commons.Assertions

cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsDensity.ql

@@ -3,7 +3,9 @@
  * @description All functions of more than 10 lines should have at least one assertion.
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-density
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       reliability
  */
 
 import semmle.code.cpp.commons.Assertions

cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsNonBoolean.ql

@@ -4,6 +4,7 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-non-boolean
  * @problem.severity warning
+ * @tags correctness
  */
 
 import semmle.code.cpp.commons.Assertions

cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsSideEffect.ql

@@ -4,6 +4,7 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-side-effect
  * @problem.severity warning
+ * @tags correctness
  */
 
 import semmle.code.cpp.commons.Assertions