JS: Added comment to explain exclusion of FunctionExpr

Napalys · Napalys · commit 15b1dae9b1be · 2025-06-02T17:35:23.000+02:00
diff --git a/javascript/ql/lib/Expressions/ExprHasNoEffect.qll b/javascript/ql/lib/Expressions/ExprHasNoEffect.qll
@@ -140,6 +140,8 @@ predicate isCompoundExpression(Expr e) {
   e instanceof SeqExpr
   or
   e instanceof ParExpr and
+  // Parenthesized function expressions like `(function() {...})` should still be flagged
+  // as useless when not invoked, so we exclude them
   not e.stripParens() instanceof FunctionExpr
 }
 

Original file line number	Diff line number	Diff line change
`@@ -140,6 +140,8 @@ predicate isCompoundExpression(Expr e) {`
`140`	`140`	`e instanceof SeqExpr`
`141`	`141`	`or`
`142`	`142`	`e instanceof ParExpr and`
	`143`	+ // Parenthesized function expressions like `(function() {...})` should still be flagged
	`144`	`+ // as useless when not invoked, so we exclude them`
`143`	`145`	`not e.stripParens() instanceof FunctionExpr`
`144`	`146`	`}`
`145`	`147`