rename getHighLight() -> getAlertLocation()

Author: erik-krogh

javascript/ql/src/Security/CWE-078/UnsafeShellCommandConstruction.ql

@@ -18,5 +18,5 @@ import DataFlow::PathGraph
 
 from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink, Sink sinkNode
 where cfg.hasFlowPath(source, sink) and sinkNode = sink.getNode()
-select sinkNode.getHighLight(), source, sink, "$@ based on libary input is later used in $@.",
-  sinkNode.getHighLight(), sinkNode.getSinkType(), sinkNode.getCommandExecution(), "shell command"
+select sinkNode.getAlertLocation(), source, sink, "$@ based on libary input is later used in $@.",
+  sinkNode.getAlertLocation(), sinkNode.getSinkType(), sinkNode.getCommandExecution(), "shell command"

javascript/ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll

@@ -36,7 +36,7 @@ module UnsafeShellCommandConstruction {
      * Gets the node that should be highlighted for this sink.
      * E.g. for a string concatenation, the sink is one of the leaves and the highlight is the concatenation root.
      */
-    abstract DataFlow::Node getHighLight();
+    abstract DataFlow::Node getAlertLocation();
   }
 
   /**
@@ -156,7 +156,7 @@ module UnsafeShellCommandConstruction {
 
     override SystemCommandExecution getCommandExecution() { result = sys }
 
-    override DataFlow::Node getHighLight() { result = root }
+    override DataFlow::Node getAlertLocation() { result = root }
   }
 
   /**
@@ -181,7 +181,7 @@ module UnsafeShellCommandConstruction {
 
     override SystemCommandExecution getCommandExecution() { result = sys }
 
-    override DataFlow::Node getHighLight() { result = this }
+    override DataFlow::Node getAlertLocation() { result = this }
   }
 
   /**
@@ -203,7 +203,7 @@ module UnsafeShellCommandConstruction {
 
     override SystemCommandExecution getCommandExecution() { result = sys }
 
-    override DataFlow::Node getHighLight() { result = this }
+    override DataFlow::Node getAlertLocation() { result = this }
   }
 
   /**