Skip to content

Commit 0f33bf1

Browse files
committed
JS: Add missing Alert expectations
1 parent 01e1fc4 commit 0f33bf1

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ var server = http.createServer(function(req, res) {
6161
var express = require('express');
6262
var application = express();
6363

64-
var views_local = (req, res) => res.render(req.params[0]);
64+
var views_local = (req, res) => res.render(req.params[0]); // $ Alert
6565
application.get('/views/*', views_local);
6666

6767
var views_imported = require("./views");
@@ -72,10 +72,10 @@ var server = http.createServer(function(req, res) {
7272
var server = http.createServer(function(req, res) {
7373
let path = url.parse(req.url, true).query.path;
7474

75-
res.write(fs.readFileSync(fs.realpathSync(path)));
75+
res.write(fs.readFileSync(fs.realpathSync(path))); // $ Alert
7676
fs.realpath(path,
7777
function(err, realpath){
78-
res.write(fs.readFileSync(realpath));
78+
res.write(fs.readFileSync(realpath)); // $ Alert
7979
}
8080
);
8181

javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/express.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ let app = express();
55
app.use(fileUpload());
66

77
app.get("/some/path", function (req, res) {
8-
req.files.foo.mv(req.query.bar);
8+
req.files.foo.mv(req.query.bar); // $ Alert
99
});

javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/pupeteer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ const parseTorrent = require('parse-torrent');
66

77
const browser = await puppeteer.launch();
88
const page = await browser.newPage();
9-
await page.pdf({ path: tainted, format: 'a4' });
9+
await page.pdf({ path: tainted, format: 'a4' }); // $ Alert
1010

1111
const pages = await browser.pages();
1212
for (let i = 0; i < something(); i++) {
13-
pages[i].screenshot({ path: tainted });
13+
pages[i].screenshot({ path: tainted }); // $ Alert
1414
}
1515

1616
await browser.close();
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = (req, res) => res.render(req.params[0]);
1+
module.exports = (req, res) => res.render(req.params[0]); // $ Alert

0 commit comments

Comments
 (0)