Replace cast to DataFlow::CallNode

maikypedia · alexrford · web-flow · commit 0dec4876f176 · 2023-08-03T17:08:35.000+02:00
Co-authored-by: Alex Ford &lt;alexrford@users.noreply.github.com&gt;
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Ldap.qll b/ruby/ql/lib/codeql/ruby/frameworks/Ldap.qll
@@ -53,7 +53,11 @@ module NetLdap {
     }
 
     DataFlow::Node getAuthValue(string arg) {
-      result = this.getKeywordArgument("auth").(DataFlow::CallNode).getKeywordArgument(arg)
+      result =
+        this.getKeywordArgument("auth")
+            .(DataFlow::HashLiteralNode)
+            .getElementFromKey(any(Ast::ConstantValue cv | cv.isStringlikeValue(arg)))
+    }
     }
 
   }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,11 @@ module NetLdap {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`DataFlow::Node getAuthValue(string arg) {`
`56`		`- result = this.getKeywordArgument("auth").(DataFlow::CallNode).getKeywordArgument(arg)`
	`56`	`+ result =`
	`57`	`+ this.getKeywordArgument("auth")`
	`58`	`+ .(DataFlow::HashLiteralNode)`
	`59`	`+ .getElementFromKey(any(Ast::ConstantValue cv \| cv.isStringlikeValue(arg)))`
	`60`	`+ }`
`57`	`61`	`}`
`58`	`62`
`59`	`63`	`}`