JS: add more React tests

Author: Esben Sparre Andreasen

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent.expected

@@ -14,6 +14,7 @@
 | props.js:2:5:3:5 | class C ... {\\n    } |
 | props.js:13:31:17:5 | {\\n      ... }\\n    } |
 | props.js:26:5:28:5 | functio ... ;\\n    } |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} |
 | statePropertyReads.js:1:1:13:1 | class R ...     }\\n} |
 | statePropertyWrites.js:1:1:34:1 | class W ...    };\\n} |
 | statePropertyWrites.js:36:19:45:1 | {\\n  ren ... ;\\n  }\\n} |

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent_getADirectPropsSource.expected

@@ -15,6 +15,7 @@
 | probably-a-component.js:1:1:6:1 | class H ...     }\\n} | probably-a-component.js:3:9:3:18 | this.props |
 | props.js:2:5:3:5 | class C ... {\\n    } | props.js:2:37:2:36 | args |
 | props.js:26:5:28:5 | functio ... ;\\n    } | props.js:26:16:26:20 | props |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | rare-lifecycle-methods.js:1:33:1:32 | args |
 | statePropertyWrites.js:36:19:45:1 | {\\n  ren ... ;\\n  }\\n} | statePropertyWrites.js:38:24:38:33 | this.props |
 | thisAccesses.js:31:2:36:1 | functio ... iv/>;\\n} | thisAccesses.js:31:12:31:16 | props |
 | thisAccesses.js:47:1:52:1 | class C ...     }\\n} | thisAccesses.js:48:18:48:18 | y |

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent_getAPreviousStateSource.expected

@@ -0,0 +1,2 @@
+| statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | statePropertyReads.js:7:24:7:32 | prevState |
+| statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | statePropertyReads.js:10:35:10:43 | prevState |

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent_getAPreviousStateSource.ql

@@ -0,0 +1,4 @@
+import semmle.javascript.frameworks.React
+
+from ReactComponent c
+select c, c.getAPreviousStateSource()

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent_getInstanceMethod.expected

@@ -10,6 +10,8 @@
 | probably-a-component.js:1:1:6:1 | class H ...     }\\n} | render | probably-a-component.js:2:11:5:5 | () {\\n   ... ;\\n    } |
 | props.js:13:31:17:5 | {\\n      ... }\\n    } | getDefaultProps | props.js:14:24:16:9 | () {\\n   ...       } |
 | props.js:26:5:28:5 | functio ... ;\\n    } | render | props.js:26:5:28:5 | functio ... ;\\n    } |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | getSnapshotBeforeUpdate | rare-lifecycle-methods.js:8:28:10:5 | (prevPr ... ;\\n    } |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | shouldComponentUpdate | rare-lifecycle-methods.js:5:26:7:5 | (nextPr ... ;\\n    } |
 | statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | componentDidUpdate | statePropertyReads.js:10:23:12:5 | (prevPr ... ;\\n    } |
 | statePropertyWrites.js:1:1:34:1 | class W ...    };\\n} | getInitialState | statePropertyWrites.js:25:20:29:5 | () { // ... ;\\n    } |
 | statePropertyWrites.js:36:19:45:1 | {\\n  ren ... ;\\n  }\\n} | getInitialState | statePropertyWrites.js:40:20:44:3 | functio ...  };\\n  } |

javascript/ql/test/library-tests/frameworks/ReactJS/ReactComponent_ref.expected

@@ -31,6 +31,10 @@
 | props.js:13:31:17:5 | {\\n      ... }\\n    } | props.js:14:24:14:23 | this |
 | props.js:26:5:28:5 | functio ... ;\\n    } | props.js:26:5:26:4 | this |
 | props.js:26:5:28:5 | functio ... ;\\n    } | props.js:34:5:34:55 | new C({ ... ctor"}) |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | rare-lifecycle-methods.js:1:33:1:32 | this |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | rare-lifecycle-methods.js:2:36:2:35 | this |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | rare-lifecycle-methods.js:5:26:5:25 | this |
+| rare-lifecycle-methods.js:1:1:11:1 | class C ...     }\\n} | rare-lifecycle-methods.js:8:28:8:27 | this |
 | statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | statePropertyReads.js:2:16:2:15 | this |
 | statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | statePropertyReads.js:3:9:3:12 | this |
 | statePropertyReads.js:1:1:13:1 | class R ...     }\\n} | statePropertyReads.js:5:9:5:12 | this |

javascript/ql/test/library-tests/frameworks/ReactJS/rare-lifecycle-methods.js

@@ -0,0 +1,11 @@
+class C extends React.Component {
+    static getDerivedStateFromProps(props, state) {
+        return {};
+    }
+    shouldComponentUpdate(nextProps, nextState) {
+        return true;
+    }
+    getSnapshotBeforeUpdate(prevProps, prevState) {
+        return {};
+    }
+}

javascript/ql/test/library-tests/frameworks/ReactJS/react.expected

@@ -13,6 +13,7 @@
 | plainfn.js:22:16:22:20 | React |
 | props.js:2:21:2:25 | React |
 | props.js:13:13:13:17 | React |
+| rare-lifecycle-methods.js:1:17:1:21 | React |
 | requiredReactRefs.js:1:13:1:28 | require("react") |
 | requiredReactRefs.js:3:1:3:5 | React |
 | requiredReactRefs.js:6:5:6:9 | React |

javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/UnusedOrUndefinedStateProperty.expected

@@ -2,5 +2,7 @@
 | undefined.js:1:1:1:34 | class C ...     }\\n} | Component state property 'notWrittenButReadInChain' is $@, but it is never written. | undefined.js:9:9:9:43 | this.st ... InChain | read |
 | undefined.js:32:1:32:34 | class C ...     }\\n} | Component state property 'notWrittenThrougExternalPropertyAccess' is $@, but it is never written. | undefined.js:35:9:35:57 | this.st ... yAccess | read |
 | undefined.js:61:19:61:19 | {\\n    r ... ;\\n  }\\n} | Component state property 'notWrittenInKnownInitializerObject' is $@, but it is never written. | undefined.js:64:9:64:53 | this.st ... rObject | read |
+| undefined.js:159:1:159:35 | class C ...     }\\n} | Component state property 'writeIn_getDerivedStateFromProps' is $@, but it is never written. | undefined.js:166:9:166:51 | this.st ... omProps | read |
 | unused.js:1:1:1:34 | class C ...     }\\n} | Component state property 'notRead' is $@, but it is never read. | unused.js:6:9:6:26 | this.state.notRead | written |
 | unused.js:27:1:27:34 | class C ...     }\\n} | Component state property 'notReadThrougExternaPropertyAccess' is $@, but it is never read. | unused.js:30:9:30:53 | this.st ... yAccess | written |
+| unused.js:64:1:64:34 | class C ...    }\\n\\n} | Component state property 'readIn_getDerivedStateFromProps' is $@, but it is never read. | unused.js:71:9:71:50 | this.st ... omProps | written |

javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/undefined.js

@@ -156,4 +156,15 @@ React.createClass({
     mixins: [{ f: () => this.state.writtenThroughMixin = 42 }]
 });
 
+class C11 extends React.Component {
+
+    static getDerivedStateFromProps(p, s) {
+        return { writeIn_getDerivedStateFromProps};
+    }
+
+    otherMethod() {
+        this.state.writeIn_getDerivedStateFromProps; // OK
+    }
+}
+
 //semmle-extractor-options: --experimental