Merge pull request #3497 from esbena/js/yield-and-local-objects

Approved by asgerf, erik-krogh

Author: semmle-qlci

change-notes/1.25/analysis-javascript.md

@@ -41,6 +41,7 @@
 | Unknown directive (`js/unknown-directive`) | Less results | This query no longer flags directives generated by the Babel compiler. |
 | Code injection (`js/code-injection`) | More results | More potential vulnerabilities involving NoSQL code operators are now recognized. |
 | Zip Slip (`js/zipslip`) | More results | This query now recognizes additional vulnerabilities. |
+| Unused property (`js/unused-property`) | Less results | This query no longer flags properties of objects that are operands of `yield` expressions. |
 
 ## Changes to libraries
 

javascript/ql/src/semmle/javascript/dataflow/LocalObjects.qll

@@ -12,6 +12,8 @@ private predicate isEscape(DataFlow::Node escape, string cause) {
   or
   escape = any(DataFlow::FunctionNode fun).getAReturn() and cause = "return"
   or
+  escape = any(YieldExpr yield).getOperand().flow() and cause = "yield"
+  or
   escape = any(ThrowStmt t).getExpr().flow() and cause = "throw"
   or
   escape = any(GlobalVariable v).getAnAssignedExpr().flow() and cause = "global"

javascript/ql/test/library-tests/LocalObjects/tst.js

@@ -89,3 +89,9 @@
 	let bound = {};
 	bound::unknown();
 });
+
+(async function* f() {
+  yield* {
+    get p() { }
+  };
+});

javascript/ql/test/query-tests/Declarations/UnusedProperty/tst-yield.js

@@ -0,0 +1,5 @@
+async function* f() {
+  yield* {
+    get p() { }
+  };
+}