Swift: Address QL-for-QL alerts.

Author: geoffw0

swift/ql/lib/codeql/swift/security/WeakPasswordHashingExtensions.qll

@@ -42,9 +42,8 @@ class WeakPasswordHashingAdditionalFlowStep extends Unit {
  * for the weak sensitive data hashing query is a sink for weak password
  * hashing as well.
  */
-private class InheritedWeakPasswordHashingSink extends WeakPasswordHashingSink {
-  InheritedWeakPasswordHashingSink() { this instanceof WeakSensitiveDataHashingSink }
-
+private class InheritedWeakPasswordHashingSink extends WeakPasswordHashingSink instanceof WeakSensitiveDataHashingSink
+{
   override string getAlgorithm() { result = this.(WeakSensitiveDataHashingSink).getAlgorithm() }
 }
 

swift/ql/lib/codeql/swift/security/WeakPasswordHashingQuery.qll

@@ -5,7 +5,6 @@
 
 import swift
 import codeql.swift.security.SensitiveExprs
-import codeql.swift.dataflow.DataFlow
 import codeql.swift.dataflow.TaintTracking
 import codeql.swift.security.WeakPasswordHashingExtensions
 

swift/ql/src/queries/Security/CWE-328/WeakPasswordHashing.qhelp

@@ -26,7 +26,7 @@
                 <strong>Brute force</strong>. If you know a hash value <code>h(x)</code>,
                 you should not be able to find an input <code>y</code> that computes to that hash value
                 using brute force attacks without significant computational effort.
-            <li>
+            </li>
         </ul>
 
         <p>