Throw ParseError for invalid extends clause and add test cases

Author: Napalys

javascript/extractor/src/com/semmle/ts/extractor/TypeScriptASTConverter.java

@@ -931,7 +931,7 @@ private List<ITypeExpression> convertSuperInterfaceClause(JsonArray supers) thro
     for (JsonElement elt : supers) {
       JsonObject superType = elt.getAsJsonObject();
       ITypeExpression objectType = convertChildAsType(superType, "expression");
-      if (objectType == null) continue;
+      if (objectType == null) throw new ParseError("Invalid extends clause: expected a type expression", getSourceLocation(superType).getStart());
       List<ITypeExpression> typeArguments = convertChildrenAsTypes(superType, "typeArguments");
       if (typeArguments.isEmpty()) {
         result.add(objectType);

javascript/extractor/tests/ts/input/invalidExtends.ts

@@ -0,0 +1,5 @@
+interface Invalid extends (foo.bar), (foo).bar, foo[bar], foo?.bar, foo!.bar, foo(), import.meta {}
+interface Employee extends Person {
+    position: string;
+    salary: number;
+}

javascript/extractor/tests/ts/output/trap/invalidExtends.ts.trap

@@ -0,0 +1,56 @@
+#10000=@"/invalidExtends.ts;sourcefile"
+files(#10000,"/invalidExtends.ts")
+#10001=@"/;folder"
+folders(#10001,"/")
+containerparent(#10001,#10000)
+#10002=@"loc,{#10000},0,0,0,0"
+locations_default(#10002,#10000,0,0,0,0)
+hasLocation(#10000,#10002)
+#20000=@"global_scope"
+scopes(#20000,0)
+#20001=@"script;{#10000},1,1"
+toplevels(#20001,0)
+#20002=@"loc,{#10000},1,1,1,1"
+locations_default(#20002,#10000,1,1,1,1)
+hasLocation(#20001,#20002)
+#20003=*
+js_parse_errors(#20003,#20001,"Error: Invalid extends clause: expected a type expression","interface Invalid extends (foo.bar), (foo).bar, foo[bar], foo?.bar, foo!.bar, foo(), import.meta {}
+")
+#20004=@"loc,{#10000},1,27,1,27"
+locations_default(#20004,#10000,1,27,1,27)
+hasLocation(#20003,#20004)
+#20005=*
+lines(#20005,#20001,"interface Invalid extends (foo.bar), (foo).bar, foo[bar], foo?.bar, foo!.bar, foo(), import.meta {}","
+")
+#20006=@"loc,{#10000},1,1,1,99"
+locations_default(#20006,#10000,1,1,1,99)
+hasLocation(#20005,#20006)
+#20007=*
+lines(#20007,#20001,"interface Employee extends Person {","
+")
+#20008=@"loc,{#10000},2,1,2,35"
+locations_default(#20008,#10000,2,1,2,35)
+hasLocation(#20007,#20008)
+#20009=*
+lines(#20009,#20001,"    position: string;","
+")
+#20010=@"loc,{#10000},3,1,3,21"
+locations_default(#20010,#10000,3,1,3,21)
+hasLocation(#20009,#20010)
+indentation(#10000,3," ",4)
+#20011=*
+lines(#20011,#20001,"    salary: number;","
+")
+#20012=@"loc,{#10000},4,1,4,19"
+locations_default(#20012,#10000,4,1,4,19)
+hasLocation(#20011,#20012)
+indentation(#10000,4," ",4)
+#20013=*
+lines(#20013,#20001,"}","
+")
+#20014=@"loc,{#10000},5,1,5,1"
+locations_default(#20014,#10000,5,1,5,1)
+hasLocation(#20013,#20014)
+numlines(#20001,5,0,0)
+numlines(#10000,5,0,0)
+filetype(#10000,"typescript")