CPP: Tag the JPL_C LOC-4 queries.

geoffw0 · geoffw0 · commit 0855543ac43d · 2018-11-23T10:31:37.000Z
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUse.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUse.ql
@@ -3,7 +3,9 @@
  * @description The use of the preprocessor must be limited to inclusion of header files and simple macro definitions.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseIfdef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseIfdef.ql
@@ -3,7 +3,9 @@
  * @description The use of conditional compilation directives must be kept to a minimum -- e.g. for header guards only.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-ifdef
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUsePartial.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUsePartial.ql
@@ -3,7 +3,9 @@
  * @description Macros must expand to complete syntactic units -- "#define MY_IF if(" is not legal.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-partial
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseUndisciplined.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseUndisciplined.ql
@@ -3,7 +3,9 @@
  * @description Macros are not allowed to use complex preprocessor features like variable argument lists and token pasting.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-undisciplined
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 21/MacroInBlock.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 21/MacroInBlock.ql
@@ -3,7 +3,9 @@
  * @description Macros shall not be #define'd within a function or a block.
  * @kind problem
  * @id cpp/jpl-c/macro-in-block
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 22/UseOfUndef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 22/UseOfUndef.ql
@@ -3,7 +3,9 @@
  * @description #undef shall not be used.
  * @kind problem
  * @id cpp/jpl-c/use-of-undef
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 23/MismatchedIfdefs.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 23/MismatchedIfdefs.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/mismatched-ifdefs
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleStmtsPerLine.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleStmtsPerLine.ql
@@ -3,7 +3,9 @@
  * @description Putting more than one statement on a single line hinders program understanding.
  * @kind problem
  * @id cpp/jpl-c/multiple-stmts-per-line
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleVarDeclsPerLine.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleVarDeclsPerLine.ql
@@ -3,7 +3,9 @@
  * @description There should be no more than one variable declaration per line.
  * @kind problem
  * @id cpp/jpl-c/multiple-var-decls-per-line
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 25/FunctionSizeLimits.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 25/FunctionSizeLimits.ql
@@ -3,7 +3,9 @@
  * @description Function length should be limited to what can be printed on a single sheet of paper (60 lines). Number of parameters is limited to 6 or fewer.
  * @kind problem
  * @id cpp/jpl-c/function-size-limits
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 26/DeclarationPointerNesting.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 26/DeclarationPointerNesting.ql
@@ -3,7 +3,9 @@
  * @description The declaration of an object should contain no more than two levels of indirection.
  * @kind problem
  * @id cpp/jpl-c/declaration-pointer-nesting
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 27/PointerDereferenceInStmt.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 27/PointerDereferenceInStmt.ql
@@ -3,7 +3,9 @@
  * @description Statements should contain no more than two levels of dereferencing per object.
  * @kind problem
  * @id cpp/jpl-c/pointer-dereference-in-stmt
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerDereferenceMacro.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerDereferenceMacro.ql
@@ -3,7 +3,9 @@
  * @description Pointer dereference operations should not be hidden in macro definitions.
  * @kind problem
  * @id cpp/jpl-c/hidden-pointer-dereference-macro
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerIndirectionTypedef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerIndirectionTypedef.ql
@@ -3,7 +3,9 @@
  * @description Pointer indirection may not be hidden by typedefs -- "typedef int* IntPtr;" is not allowed.
  * @kind problem
  * @id cpp/jpl-c/hidden-pointer-indirection-typedef
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer.ql
@@ -3,7 +3,10 @@
  * @description Non-constant pointers to functions should not be used.
  * @kind problem
  * @id cpp/jpl-c/non-const-function-pointer
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 30/FunctionPointerConversions.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 30/FunctionPointerConversions.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/function-pointer-conversions
  * @problem.severity warning
+ * @precision low
+ * @tags correctness
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 31/IncludesFirst.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 31/IncludesFirst.ql
@@ -3,7 +3,9 @@
  * @description #include directives in a file shall only be preceded by other preprocessor directives or comments.
  * @kind problem
  * @id cpp/jpl-c/includes-first
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
