bringing back mayThrowException to make it cleaner/easier for backwards compatibility.

Author: bdrodes

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll

@@ -363,11 +363,11 @@ class TranslatedFunctionCall extends TranslatedCallExpr, TranslatedDirectCall {
   }
 
   final override predicate mayThrowException() {
-    expr.getTarget().(ThrowingFunction).raisesException(_)
+    expr.getTarget().(ThrowingFunction).mayThrowException(_)
   }
 
   final override predicate mustThrowException() {
-    expr.getTarget().(ThrowingFunction).raisesException(true)
+    expr.getTarget().(ThrowingFunction).mayThrowException(true)
   }
 }
 

cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll

@@ -66,23 +66,10 @@ abstract class ThrowingFunction extends ExceptionAnnotation {
    * Do not specify `none()` if no exception is raised, instead use the
    * `NonThrowingFunction` class instead.
    */
-  abstract predicate raisesException(boolean unconditional);
-
-  /**
-   * DEPRECATES: use/extend `raisesException` instead.
-   */
-  deprecated predicate mayThrowException(boolean unconditional){
-    this.raisesException(unconditional)
-  }
+  abstract predicate mayThrowException(boolean unconditional);
 
   /**
    * Holds if this function will always raise an exception if called
    */
-  final predicate alwaysRaisesException() { this.raisesException(true) }
-
-  /**
-   * Holds if this function may raise an exception if called but
-   * it is not guaranteed to do so. I.e., the function does not always raise an exception.
-   */
-  final predicate mayRaiseException() { this.raisesException(false) }
+  final predicate alwaysRaisesException() { this.mayThrowException(true) }
 }