Added external storage test case

Author: egregius313

java/ql/test/query-tests/security/CWE-094/APKInstallation.expected

@@ -1,12 +1,14 @@
 edges
 nodes
-| APKInstallation.java:13:31:13:58 | fromFile(...) | semmle.label | fromFile(...) |
-| APKInstallation.java:20:31:20:44 | parse(...) | semmle.label | parse(...) |
-| APKInstallation.java:28:24:28:38 | parse(...) | semmle.label | parse(...) |
-| APKInstallation.java:35:24:35:51 | fromFile(...) | semmle.label | fromFile(...) |
+| APKInstallation.java:14:31:14:58 | fromFile(...) | semmle.label | fromFile(...) |
+| APKInstallation.java:21:31:21:44 | parse(...) | semmle.label | parse(...) |
+| APKInstallation.java:29:24:29:38 | parse(...) | semmle.label | parse(...) |
+| APKInstallation.java:36:24:36:51 | fromFile(...) | semmle.label | fromFile(...) |
+| APKInstallation.java:43:31:43:48 | fromFile(...) | semmle.label | fromFile(...) |
 subpaths
 #select
-| APKInstallation.java:13:31:13:58 | fromFile(...) | APKInstallation.java:13:31:13:58 | fromFile(...) | APKInstallation.java:13:31:13:58 | fromFile(...) | Arbitrary Android APK installation. |
-| APKInstallation.java:20:31:20:44 | parse(...) | APKInstallation.java:20:31:20:44 | parse(...) | APKInstallation.java:20:31:20:44 | parse(...) | Arbitrary Android APK installation. |
-| APKInstallation.java:28:24:28:38 | parse(...) | APKInstallation.java:28:24:28:38 | parse(...) | APKInstallation.java:28:24:28:38 | parse(...) | Arbitrary Android APK installation. |
-| APKInstallation.java:35:24:35:51 | fromFile(...) | APKInstallation.java:35:24:35:51 | fromFile(...) | APKInstallation.java:35:24:35:51 | fromFile(...) | Arbitrary Android APK installation. |
+| APKInstallation.java:14:31:14:58 | fromFile(...) | APKInstallation.java:14:31:14:58 | fromFile(...) | APKInstallation.java:14:31:14:58 | fromFile(...) | Arbitrary Android APK installation. |
+| APKInstallation.java:21:31:21:44 | parse(...) | APKInstallation.java:21:31:21:44 | parse(...) | APKInstallation.java:21:31:21:44 | parse(...) | Arbitrary Android APK installation. |
+| APKInstallation.java:29:24:29:38 | parse(...) | APKInstallation.java:29:24:29:38 | parse(...) | APKInstallation.java:29:24:29:38 | parse(...) | Arbitrary Android APK installation. |
+| APKInstallation.java:36:24:36:51 | fromFile(...) | APKInstallation.java:36:24:36:51 | fromFile(...) | APKInstallation.java:36:24:36:51 | fromFile(...) | Arbitrary Android APK installation. |
+| APKInstallation.java:43:31:43:48 | fromFile(...) | APKInstallation.java:43:31:43:48 | fromFile(...) | APKInstallation.java:43:31:43:48 | fromFile(...) | Arbitrary Android APK installation. |

java/ql/test/query-tests/security/CWE-094/APKInstallation.java

@@ -1,6 +1,7 @@
 import android.app.Activity;
 import android.content.Intent;
 import android.net.Uri;
+import android.os.Environment;
 
 import java.io.File;
 
@@ -35,4 +36,11 @@ public void installAPK3(String path) {
         intent.setData(Uri.fromFile(new File(path)));
         startActivity(intent);
     }
+
+    public void installAPK4(String path) {
+        File file = new File(Environment.getExternalStorageDirectory(), path);
+        Intent intent = new Intent(Intent.ACTION_VIEW);
+        intent.setDataAndType(Uri.fromFile(file), APK_MIMETYPE);
+        startActivity(intent);
+    }
 }