change name of Useless cat

Author: erik-krogh

change-notes/1.24/analysis-javascript.md

@@ -46,7 +46,7 @@
 | Polynomial regular expression used on uncontrolled data (`js/polynomial-redos`) | security, external/cwe/cwe-730, external/cwe/cwe-400 | Highlights expensive regular expressions that may be used on malicious input. Results are shown on LGTM by default. | 
 | Prototype pollution in utility function (`js/prototype-pollution-utility`) | security, external/cwe/cwe-400, external/cwe/cwe-471 | Highlights recursive copying operations that are susceptible to prototype pollution. Results are shown on LGTM by default. |
 | Unsafe jQuery plugin (`js/unsafe-jquery-plugin`) | Highlights potential XSS vulnerabilities in unsafely designed jQuery plugins. Results are shown on LGTM by default. |
-| Useless use of cat (`js/useless-use-of-cat`) | correctness, security, maintainability | Highlights command executions of `cat` where the fs API should be used instead. Results are shown on LGTM by default. |
+| Unnecessary use of `cat` process (`js/unnecessary-use-of-cat`) | correctness, security, maintainability | Highlights command executions of `cat` where the fs API should be used instead. Results are shown on LGTM by default. |
 
 
 ## Changes to existing queries

javascript/ql/src/Security/CWE-078/UselessUseOfCat.ql

@@ -1,10 +1,10 @@
 /**
- * @name Useless use of cat
+ * @name Unnecessary use of `cat` process
  * @description Using the  `cat` process to read a file is unnecessarily complex, inefficient, unportable, and can lead to subtle bugs, or even security vulnerabilities.
  * @kind problem
  * @problem.severity error
  * @precision high
- * @id js/useless-use-of-cat
+ * @id js/unnecessary-use-of-cat
  * @tags correctness
  *       security
  *       maintainability
@@ -22,4 +22,4 @@ where
   if cat.isSync()
   then message = " Can be replaced with a call to fs.readFileSync(..)."
   else message = " Can be replaced with a call to fs.readFile(..)."
-select cat.asExpr().(FirstLineOf), "Useless use of `cat`." + message
+select cat.asExpr().(FirstLineOf), "Unnecessary use of `cat` process." + message