Skip to content

Commit fba7872

Browse files
committed
Address review comments
1 parent 28bfb7b commit fba7872

File tree

9 files changed

+18
-54
lines changed

9 files changed

+18
-54
lines changed

lib/analyze-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/autobuild-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action-post.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/resolve-environment-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/setup-codeql-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/start-proxy-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/upload-sarif-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/status-report.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -625,19 +625,15 @@ export async function sendUnhandledErrorStatusReport(
625625
undefined,
626626
undefined,
627627
logger,
628-
`Unhandled error: ${getErrorMessage(error)}`,
628+
`Unhandled CodeQL Action error: ${getErrorMessage(error)}`,
629629
error instanceof Error ? error.stack : undefined,
630630
);
631631
if (statusReport !== undefined) {
632632
await sendStatusReport(statusReport);
633-
} else if (isInTestMode()) {
634-
throw new Error(
635-
"Failed to create status report for unhandled error in test mode.",
636-
);
637633
}
638634
} catch (e) {
639635
logger.warning(
640-
`Failed to send the error status report: ${getErrorMessage(e)}.`,
636+
`Failed to send the unhandled error status report: ${getErrorMessage(e)}.`,
641637
);
642638
if (isInTestMode()) {
643639
throw e;

0 commit comments

Comments
 (0)