Merge pull request #141 from michael/iamdanfox-improve-repo-commit-method

Iamdanfox improve repo commit method closes #130

Author: ingalls

github.js

@@ -414,21 +414,25 @@
       // -------
 
       this.commit = function(parent, tree, message, cb) {
-        var data = {
-          "message": message,
-          "author": {
-            "name": options.username
-          },
-          "parents": [
-            parent
-          ],
-          "tree": tree
-        };
-
-        _request("POST", repoPath + "/git/commits", data, function(err, res) {
-          currentTree.sha = res.sha; // update latest commit
+        var user = new Github.User();
+        user.show(null, function(err, userData){
           if (err) return cb(err);
-          cb(null, res.sha);
+          var data = {
+            "message": message,
+            "author": {
+              "name": options.user,
+              "email": userData.email
+            },
+            "parents": [
+              parent
+            ],
+            "tree": tree
+          };
+          _request("POST", repoPath + "/git/commits", data, function(err, res) {
+            if (err) return cb(err);
+            currentTree.sha = res.sha; // update latest commit
+            cb(null, res.sha);
+          });
         });
       };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "github-api",
-  "version": "0.7.1",
+  "version": "0.7.2",
   "description": "A higher-level wrapper around the Github API.",
   "main": "github.js",
   "dependencies": {

test/test.repo.js

@@ -46,3 +46,23 @@ test("Repo API", function(t) {
     t.end();
 
 });
+
+test('Repo Returns commit errors correctly', function(t){
+    var timeout = setTimeout(function () { t.fail(); }, 10000);
+    var github = new Github({
+      username: test_user.USERNAME,
+      password: test_user.PASSWORD,
+      auth: "basic"
+    });
+    var repo = github.getRepo(test_user.USERNAME, test_user.REPO);
+
+    repo.commit("broken-parent-hash", "broken-tree-hash", "commit message", function(err){
+        t.ok(err, 'error thrown for bad commit');
+        t.ok(err.request);
+        t.equals(err.request.status, 422, 'Returns 422 status');
+        clearTimeout(timeout);
+        t.end();
+    });
+
+
+});

test/user.json

@@ -1,4 +1,5 @@
 {
     "USERNAME": "mikedeboertest",
-    "PASSWORD": "test1324"
+    "PASSWORD": "test1324",
+    "REPO": "github"
 }